Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clear in the logs when the example app is ready #17

Open
bfabio opened this issue Dec 30, 2020 · 0 comments
Open

Make clear in the logs when the example app is ready #17

bfabio opened this issue Dec 30, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bfabio
Copy link
Member

bfabio commented Dec 30, 2020

The example app is ready after the message

[spid-express] info: samlCert expire in 12 months

and that's documented in the README.

We shouldn't need to document that with better logging, something along the lines of

[spid-express] Getting all metadata... (this can take a while)
and
[spid-express] Getting all metadata... done. App is ready at http://foobar
@bfabio bfabio added the enhancement New feature or request label Dec 30, 2020
@bfabio bfabio added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bfabio