Fix Xcode warnings

Author: jnpdx

Downloader.h

@@ -4,7 +4,7 @@ typedef void (^DownloadCompleteCallback)(NSNumber*, NSNumber*);
 typedef void (^ErrorCallback)(NSError*);
 typedef void (^BeginCallback)(NSNumber*, NSNumber*, NSDictionary*);
 typedef void (^ProgressCallback)(NSNumber*, NSNumber*);
-typedef void (^ResumableCallback)();
+typedef void (^ResumableCallback)(void);
 
 @interface RNFSDownloadParams : NSObject
 

Downloader.m

@@ -90,7 +90,7 @@ - (void)URLSession:(NSURLSession *)session downloadTask:(NSURLSessionDownloadTas
       NSNumber* progress = [NSNumber numberWithUnsignedInt: floor(doublePercents)];
       if ([progress unsignedIntValue] % [_params.progressDivider integerValue] == 0) {
         if (([progress unsignedIntValue] != [_lastProgressValue unsignedIntValue]) || ([_bytesWritten unsignedIntegerValue] == [_contentLength longValue])) {
-          NSLog(@"---Progress callback EMIT--- %zu", [progress unsignedIntValue]);
+            NSLog(@"---Progress callback EMIT--- %u", [progress unsignedIntValue]);
           _lastProgressValue = [NSNumber numberWithUnsignedInt:[progress unsignedIntValue]];
           return _params.progressCallback(_contentLength, _bytesWritten);
         }
@@ -140,15 +140,15 @@ - (void)stopDownload
     [_task cancelByProducingResumeData:^(NSData * _Nullable resumeData) {
         if (resumeData != nil) {
             self.resumeData = resumeData;
-            _params.resumableCallback();
+            self->_params.resumableCallback();
         } else {
             NSError *error = [NSError errorWithDomain:@"RNFS"
-                                                 code:@"Aborted"
+                                                 code:0 //used to pass an NSString @"Aborted" here, but it needs an NSInteger
                                              userInfo:@{
                                                         NSLocalizedDescriptionKey: @"Download has been aborted"
                                                         }];
 
-            _params.errorCallback(error);
+            self->_params.errorCallback(error);
         }
     }];
 

RNFS.podspec

@@ -10,7 +10,7 @@ Pod::Spec.new do |s|
   s.license         = pjson["license"]
   s.author          = { "Johannes Lumpe" => "[email protected]" }
 
-  s.ios.deployment_target = '7.0'
+  s.ios.deployment_target = '8.0'
   s.tvos.deployment_target = '9.2'
 
   s.source          = { :git => "https://github.com/itinance/react-native-fs", :tag => "v#{s.version}" }

RNFSManager.h

@@ -9,7 +9,7 @@
 #import <React/RCTBridgeModule.h>
 #import <React/RCTLog.h>
 
-typedef void (^CompletionHandler)();
+typedef void (^CompletionHandler)(void);
 
 @interface RNFSManager : NSObject <RCTBridgeModule>
 

RNFSManager.m

@@ -157,8 +157,15 @@ + (BOOL)requiresMainQueueSetup
     [fH writeData:data];
 
     return resolve(nil);
-  } @catch (NSException *e) {
-    return [self reject:reject withError:e];
+  } @catch (NSException *exception) {
+    NSMutableDictionary * info = [NSMutableDictionary dictionary];
+    [info setValue:exception.name forKey:@"ExceptionName"];
+    [info setValue:exception.reason forKey:@"ExceptionReason"];
+    [info setValue:exception.callStackReturnAddresses forKey:@"ExceptionCallStackReturnAddresses"];
+    [info setValue:exception.callStackSymbols forKey:@"ExceptionCallStackSymbols"];
+    [info setValue:exception.userInfo forKey:@"ExceptionUserInfo"];
+    NSError *err = [NSError errorWithDomain:@"RNFS" code:0 userInfo:info];
+    return [self reject:reject withError:err];
   }
 }
 
@@ -808,7 +815,8 @@ + (BOOL)requiresMainQueueSetup
                   rejecter: (RCTPromiseRejectBlock) reject)
 {
   NSURL* url = [NSURL URLWithString:imageUri];
-  __block NSURL* videoURL = [NSURL URLWithString:destination];
+  //unused?
+  //__block NSURL* videoURL = [NSURL URLWithString:destination];
   __block NSError *error = nil;
 
   PHFetchResult *phAssetFetchResult = [PHAsset fetchAssetsWithALAssetURLs:@[url] options:nil];

Uploader.m

@@ -106,7 +106,7 @@ - (void)uploadFiles:(RNFSUploadParams*)params
   NSURLSession *session = [NSURLSession sessionWithConfiguration:sessionConfiguration delegate:(id)self delegateQueue:[NSOperationQueue mainQueue]];
   _task = [session dataTaskWithRequest:req completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
       NSString * str = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
-      return _params.completeCallback(str, response);
+      return self->_params.completeCallback(str, response);
   }];
   [_task resume];
   _params.beginCallback();