Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[binary] Binary streams closing tests are ignored #16

Open
dantleech opened this issue Nov 6, 2014 · 1 comment
Open

[binary] Binary streams closing tests are ignored #16

dantleech opened this issue Nov 6, 2014 · 1 comment

Comments

@dantleech
Copy link
Contributor

https://github.com/jackalope/jackalope-fs/blob/master/tests/ImplementationLoader.php#L97

Really couldn't find out to close these file handles.
@dbu
Copy link
Member

dbu commented Nov 6, 2014

i think those are mainly about the jackrabbit streams where we have a stream wrapper to avoid opening (=requesting) the stream for binary with the jackrabbit. not sure exactly what should happen here - maybe you find something in the jackalope-jackrabbit stream wrappers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbu @dantleech