Skip to content

Commit fd438c2

Browse files
authored
ci(e2e): drop e2e-headed from pull_request trigger (#1521)
Per-PR e2e-headed Chrome was the dominant PR-time wait (~10-15 min on two platforms) and on fork PRs blocks behind maintainer approval, while the actually-blocking failures it caught in the last 30 days were all e2e-test migrations missed by the authoring PR (#1461 / #1505 workspace ->session) rather than real regressions the unit/typecheck tier missed. PR feedback path is now: - typecheck / unit / lint / adapter / build ← `pull_request` (ci.yml) - extension typecheck / build ← `pull_request` (build-extension.yml) - docs build ← `pull_request` (doc-check.yml) - security audit ← `pull_request` (security.yml) E2E-headed Chrome guards: - push to main / dev (watched paths) - push v* tag (release) - nightly cron 08:00 UTC (added: catches Chrome version drift / flake drift even when no commits touch watched paths) - workflow_dispatch (manual when a PR really wants e2e signal) smoke-test was already gated on `schedule || workflow_dispatch` only (ci.yml), so no change needed there.
1 parent 1eac8e0 commit fd438c2

1 file changed

Lines changed: 9 additions & 12 deletions

File tree

.github/workflows/e2e-headed.yml

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
name: E2E Headed Chrome
22

33
on:
4+
# E2E removed from `pull_request` to keep PR feedback under ~2 minutes; PR-time
5+
# protection is the CI workflow (typecheck / unit / lint / adapter / build).
6+
# E2E still guards `main` directly, runs nightly, and on release tag push so
7+
# protocol/CDP/extension contract regressions are caught before they ship.
48
push:
59
branches: [main, dev]
610
paths:
@@ -13,18 +17,11 @@ on:
1317
- 'tests/smoke/**'
1418
- '.github/actions/setup-chrome/**'
1519
- '.github/workflows/e2e-headed.yml'
16-
pull_request:
17-
branches: [main, dev]
18-
paths:
19-
- 'extension/**'
20-
- 'src/browser/**'
21-
- 'src/daemon.ts'
22-
- 'src/execution.ts'
23-
- 'src/interceptor.ts'
24-
- 'tests/e2e/**'
25-
- 'tests/smoke/**'
26-
- '.github/actions/setup-chrome/**'
27-
- '.github/workflows/e2e-headed.yml'
20+
tags: ['v*']
21+
schedule:
22+
# Daily 08:00 UTC — catch flake / Chrome-version drift even when no commits
23+
# touched the watched paths recently.
24+
- cron: '0 8 * * *'
2825
workflow_dispatch:
2926

3027
concurrency:

0 commit comments

Comments
 (0)