Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with some mutations not being captured properly. #28

Open
jakelever opened this issue Mar 3, 2023 · 1 comment
Open

Fix issues with some mutations not being captured properly. #28

jakelever opened this issue Mar 3, 2023 · 1 comment
Assignees
@jakelever
Labels
wontfix

Comments

@jakelever
Copy link
Owner

An issue was raised over on the CIViCmine project (jakelever/civicmine#6) that some mutations are not being captured correctly. It appears to be because Spacy is now splitting some variants (e.g. T790M) into multiple tokens (T790 and M). The current Kindred variant code assumes it will be a single token. Let's change that.
@jakelever jakelever self-assigned this Mar 3, 2023
jakelever added a commit that referenced this issue Mar 3, 2023
@jakelever
Edit tests to check variant extraction for issue #28
40beb8a
jakelever added a commit that referenced this issue Mar 3, 2023
@jakelever
Fix for variant extraction bug with multiple tokens (issue #28)
ff1c0d1
@stale
Copy link

stale bot commented Jun 8, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelever jakelever

Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakelever