Fix for std::basic_string_view<char>::const_iterator not being convertible to const char * in Windows (issue #43)

enricodetoma · enricodetoma · commit 34b929799a15 · 2024-04-17T18:14:16.000+02:00
diff --git a/include/hffix.hpp b/include/hffix.hpp
@@ -900,7 +900,7 @@ class message_writer {
     \throw std::out_of_range When the remaining buffer size is too small.
     */
     void push_back_string(int tag, std::string_view s) {
-        push_back_string(tag, s.begin(), s.end());
+        push_back_string(tag, s.data(), s.data() + s.length());
     }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -900,7 +900,7 @@ class message_writer {`
`900`	`900`	`\throw std::out_of_range When the remaining buffer size is too small.`
`901`	`901`	`*/`
`902`	`902`	`void push_back_string(int tag, std::string_view s) {`
`903`		`- push_back_string(tag, s.begin(), s.end());`
	`903`	`+ push_back_string(tag, s.data(), s.data() + s.length());`
`904`	`904`	`}`
`905`	`905`	`#endif`
`906`	`906`