Skip to content

Commit 421d720

Browse files
authored
make sure defer runs (linter) (#6)
1 parent f64f119 commit 421d720

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

main.go

+12-4
Original file line numberDiff line numberDiff line change
@@ -239,12 +239,16 @@ func convertCoverage(in io.Reader, out io.Writer) error {
239239
}
240240

241241
func main() {
242+
os.Exit(gcovmain())
243+
}
244+
245+
func gcovmain() int {
242246
infileName := flag.String("infile", "", "go coverage file to read, default: <stdin>")
243247
outfileName := flag.String("outfile", "", "lcov file to write, default: <stdout>")
244248
flag.Parse()
245249
if len(flag.Args()) > 0 {
246250
flag.Usage()
247-
os.Exit(1)
251+
return 1
248252
}
249253

250254
infile := os.Stdin
@@ -253,20 +257,24 @@ func main() {
253257
if *infileName != "" {
254258
infile, err = os.Open(*infileName)
255259
if err != nil {
256-
log.Fatalf("error opening input file: %v", err)
260+
log.Printf("error opening input file: %v\n", err)
261+
return 2
257262
}
258263
defer infile.Close()
259264
}
260265
if *outfileName != "" {
261266
outfile, err = os.Create(*outfileName)
262267
if err != nil {
263-
log.Fatalf("error opening output file: %v", err)
268+
log.Printf("error opening output file: %v\n", err)
269+
return 3
264270
}
265271
defer outfile.Close()
266272
}
267273

268274
err = convertCoverage(infile, outfile)
269275
if err != nil {
270-
log.Fatalf("convert: %v", err)
276+
log.Printf("error: convert: %v", err)
277+
return 4
271278
}
279+
return 0
272280
}

0 commit comments

Comments
 (0)