From 08e6245f65b5cc1b8f13b78f917a3da0eed15906 Mon Sep 17 00:00:00 2001 From: Jannis Baum Date: Thu, 21 Nov 2024 11:23:29 -0400 Subject: [PATCH 1/2] fix(#191): macos ci node version --- .github/workflows/ci.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 10a6aa4..bde8627 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -64,6 +64,13 @@ jobs: needs: [test] runs-on: macos-latest steps: + - name: get Homebrew Node + # lists node dependencies, these need to be mirrored for the Homebrew package + run: | + brew update + brew install node + brew deps --tree --installed node + echo $PATH - name: checkout uses: actions/checkout@v4 - name: build From 878c28e61e5b1e8e5ef3dbcbde6734b6f3182bb2 Mon Sep 17 00:00:00 2001 From: Jannis Baum Date: Thu, 21 Nov 2024 11:53:43 -0400 Subject: [PATCH 2/2] feat(#191): list macos node deps in release notes --- .github/workflows/ci.yaml | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index bde8627..1272afe 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -64,24 +64,28 @@ jobs: needs: [test] runs-on: macos-latest steps: + - name: checkout + uses: actions/checkout@v4 - name: get Homebrew Node # lists node dependencies, these need to be mirrored for the Homebrew package run: | brew update brew install node - brew deps --tree --installed node - echo $PATH - - name: checkout - uses: actions/checkout@v4 + brew deps --installed --direct node > macos-deps.txt - name: build run: | yarn VIV_VERSION="${{ github.ref_name }}" make macos - - name: upload artifact + - name: upload artifact (macOS build) uses: actions/upload-artifact@v4 with: name: vivify-macos path: build/macos + - name: upload artifact (macOS dependency list) + uses: actions/upload-artifact@v4 + with: + name: macos-deps + path: macos-deps.txt release: name: Release @@ -110,6 +114,12 @@ jobs: chmod +x ./vivify-linux/* ./vivify-macos/* tar -czf vivify-linux.tar.gz vivify-linux tar -czf vivify-macos.tar.gz vivify-macos + # macos dependencies ----------------------------------------------------- + - name: download macos dependencies + uses: actions/download-artifact@v4 + with: + name: macos-deps + path: macos-deps # release notes ---------------------------------------------------------- # actions/checkout seems to have a bug where annotated tags are converted # to simple tags so we have to fetch them explicitly again @@ -129,6 +139,12 @@ jobs: >> release.md echo -e "macOS: \`$(sha256sum vivify-macos.tar.gz | cut -d' ' -f1)\`" \ >> release.md + echo -e '\n**macOS Homebrew dependencies**\n\n```plain' \ + >> release.md + cat macos-deps/macos-deps.txt \ + >> release.md + echo -e '```' \ + >> release.md - name: print release notes for logs run: cat release.md