Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to file endpoint #140

Open
Tweekism opened this issue Jul 28, 2024 Discussed in #123 · 8 comments
Open

Switch to file endpoint #140

Tweekism opened this issue Jul 28, 2024 Discussed in #123 · 8 comments
Labels
topic:infrastructure e.g. API, config type:feature New feature or request

Comments

@Tweekism
Copy link
Collaborator

Discussed in #123

Originally posted by Tweekism July 25, 2024
Is there any appetite for an option that makes vivify follow you when you switch buffers?

_Screencast from 2024-07-25 23-23-02

@jannis-baum jannis-baum added type:feature New feature or request topic:infrastructure e.g. API, config labels Jul 28, 2024
@jannis-baum
Copy link
Owner

Like I said, the way to implement this would probably be

  1. vivify.vim sends POST to vivify-server
  2. vivify-server sends message to clients at given path through existing websockets
  3. client reacts to message by running vanilla client-side JS in the browser that opens the new page on the same tab.

I.e. the same way the scrolling and buffer-updating works right now as well!

That said, the issue here on main Vivify will be to implement the endpoint for the POST request and the client-side opening of the new page. The actual "follow on buffer switch" is an issue for the vivify.vim repo :)

@jannis-baum jannis-baum changed the title Follow on buffer switch Switch to file endpoint Jul 28, 2024
@Tweekism
Copy link
Collaborator Author

Ah yeah, Sorry.

I tryed to create an issue from discussion for the SEO thing too, but it doesn't let me.

image

Clearly my GitHub-foo needs work 🫤

@Tweekism
Copy link
Collaborator Author

Do you want me to create those 2 issues over there? Or would you prefer to do it?

@jannis-baum
Copy link
Owner

No worries!

Do you want me to create those 2 issues over there? Or would you prefer to do it?

You go! What's the second issue though? Aside from the one that will use the new endpoint to change the viewer after switching buffers.

@Tweekism
Copy link
Collaborator Author

First action item so far: Mention "Markdown" more in the description of the Vim plugin (people seem to look more for Vim plugins than standalone viewers because they don't come up with the idea of a standalone viewer)

^^ This one

@jannis-baum
Copy link
Owner

Aaaah okay! Hm, not sure. I think Tuure and I already did that to some extent. If you think there is more to adjust then feel free to open the issue though.

@Tweekism
Copy link
Collaborator Author

Did he? I'll check.

@jannis-baum
Copy link
Owner

Clearly my GitHub-foo needs work 🫤

This was probably because you're not a collaborator over on that repo yet. I'll invite you there as well, maybe it'll work then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:infrastructure e.g. API, config type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants