Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/22 windows support #161

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Issue/22 windows support #161

wants to merge 3 commits into from

Conversation

Tweekism
Copy link
Collaborator

@Tweekism Tweekism commented Aug 9, 2024

Draft pull request for Windows support.

This is still early in the exploration phase, anyone wanting to contribute or follow the specific implementation details should subscribe to this thread.

More general Windows support discussion can be found on the original issue #22

List of changes so far to get server working:-

  • Use Windows specific environment variable setup for the yarn win-dev server launch script
  • Call file with double quotes instead of single quotes (the Windows version of file needs to be installed, see below)
  • Strip leading backslashes \ from file paths, like we do for forward slashes / (having backslashes after that is ok, browsers in Windows are setup to expect that).
  • Add C: back on when calling out to file

These early tests come with the following limitations:-

  • You can't use shortened home paths (~)
  • You can't access anything but C:\
  • You need to install the Windows version of the file command and add it to your Windows PATH environment variable
  • I haven't looked at the viv client at all yet, so you have to manually invoke the browser

@Tweekism Tweekism force-pushed the issue/22-windows-support branch from 9d59928 to f43d496 Compare August 9, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant