Skip to content

Commit 0cd040c

Browse files
committed
Fix KoalaPlot deprecations
1 parent 73a4422 commit 0cd040c

12 files changed

Lines changed: 44 additions & 73 deletions

File tree

app/versions/mergedManifests/debug/processDebugManifest/AndroidManifest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
<activity
3636
android:name="com.jarroyo.composeapp.MainActivity"
3737
android:exported="true"
38-
android:label="@string/app_name"
3938
android:theme="@style/Theme.ComposeApp" >
4039
<intent-filter>
4140
<action android:name="android.intent.action.MAIN" />

app/versions/mergedManifests/release/processReleaseManifest/AndroidManifest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
<activity
3737
android:name="com.jarroyo.composeapp.MainActivity"
3838
android:exported="true"
39-
android:label="@string/app_name"
4039
android:theme="@style/Theme.ComposeApp" >
4140
<intent-filter>
4241
<action android:name="android.intent.action.MAIN" />
-38 Bytes
Binary file not shown.

build-conventions/src/main/kotlin/composeapp.android-app-conventions.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ plugins {
1212
id("com.android.application")
1313
id("org.jetbrains.kotlin.plugin.compose")
1414
id("composeapp.android-conventions")
15-
//id("kotlin-parcelize")
1615
id("com.mikepenz.aboutlibraries.plugin")
1716
id("composeapp.merged-manifests-conventions")
1817
id("composeapp.dependencies-conventions")

build-conventions/src/main/kotlin/composeapp.multiplatform-library-conventions.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import com.jarroyo.composeapp.ext.android
33
import com.jarroyo.composeapp.ext.config
44
import org.gradle.accessors.dm.LibrariesForLibs
55
import org.gradle.kotlin.dsl.configure
6+
import org.gradle.kotlin.dsl.get
67
import org.gradle.kotlin.dsl.the
78
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
89

@@ -16,7 +17,7 @@ val libs = the<LibrariesForLibs>()
1617

1718
kotlin {
1819
android {
19-
namespace = "com.jarroyo.composeapp"
20+
namespace = config.android.applicationId.get()
2021
compileSdk = project.config.android.compileSdk.get()
2122
minSdk = project.config.android.minSdk.get()
2223

gradle/libs.versions.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ kotlin = "2.3.10"
2222
kotlinpoet = "2.2.0"
2323
kotlin-multiplatform = "1.10.1"
2424
kotlin-result = "2.1.0"
25+
kotlinx-datetime = "0.6.1"
2526
ksp = "2.3.5"
2627
ktlint = "0.43.0"
2728
ktor = "3.4.0"
@@ -76,7 +77,7 @@ jetbrains-compose-material3 = { module = "org.jetbrains.compose.material3:materi
7677
jetbrains-compose-runtime = { module = "org.jetbrains.compose.runtime:runtime", version.ref = "kotlin-multiplatform" }
7778
jetbrains-compose-ui = { module = "org.jetbrains.compose.ui:ui", version.ref = "kotlin-multiplatform" }
7879
jetbrains-compose-ui-graphics = { module = "org.jetbrains.compose.ui:ui-graphics", version.ref = "kotlin-multiplatform" }
79-
## jetbrains-kotlin-datetime = { module = "org.jetbrains.kotlinx:kotlinx-datetime", version.ref = "kotlinx-datetime" }
80+
jetbrains-kotlin-datetime = { module = "org.jetbrains.kotlinx:kotlinx-datetime", version.ref = "kotlinx-datetime" }
8081
jetbrains-kotlin-extensions = { module = "org.jetbrains.kotlin:kotlin-android-extensions", version.ref = "kotlin" }
8182
jetbrains-kotlin-stdlib = { module = "org.jetbrains.kotlin:kotlin-stdlib-jdk8", version.ref = "kotlin" }
8283
jetbrains-kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlin" }

modules/feature-electricity/src/commonMain/kotlin/com/jarroyo/feature/electricity/ui/ElectricityScreen.kt

Lines changed: 37 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,17 @@ import com.jarroyo.library.ui.shared.theme.Spacing
4747
import com.kizitonwose.calendar.core.minusDays
4848
import com.kizitonwose.calendar.core.now
4949
import io.github.koalaplot.core.ChartLayout
50-
import io.github.koalaplot.core.line.LinePlot
50+
import io.github.koalaplot.core.line.LinePlot2
5151
import io.github.koalaplot.core.style.LineStyle
5252
import io.github.koalaplot.core.util.ExperimentalKoalaPlotApi
53+
import io.github.koalaplot.core.xygraph.AxisContent
54+
import io.github.koalaplot.core.xygraph.AxisStyle
55+
import io.github.koalaplot.core.xygraph.CategoryAxisModel
5356
import io.github.koalaplot.core.xygraph.DefaultPoint
57+
import io.github.koalaplot.core.xygraph.XYGraph
5458
import io.github.koalaplot.core.xygraph.XYGraphScope
59+
import io.github.koalaplot.core.xygraph.rememberFloatLinearAxisModel
60+
import io.github.koalaplot.core.xygraph.rememberGridStyle
5561
import kotlinx.coroutines.flow.Flow
5662
import kotlinx.coroutines.flow.collect
5763
import kotlinx.coroutines.flow.onEach
@@ -140,51 +146,37 @@ private fun ColumnScope.XYSamplePlot(state: State) {
140146
val minGraph = minValue.toFloat() - 20
141147
val maxGraph = maxValue.toFloat() + 20
142148

149+
val points = mapIndexed { index, value ->
150+
if (value.value == minValue) {
151+
hourMin = hourList[index]
152+
}
153+
if (value.value == maxValue) {
154+
hourMax = hourList[index]
155+
}
156+
Logger.d("JAE ${hourList[index]} - $value")
157+
DefaultPoint(hourList[index], value.value.toFloat())
158+
}
143159
ChartLayout(modifier = Modifier.fillMaxSize()) {
144-
val points = mapIndexed { index, value ->
145-
if (value.value == minValue) {
146-
hourMin = hourList[index]
147-
}
148-
if (value.value == maxValue) {
149-
hourMax = hourList[index]
150-
}
151-
Logger.d("JAE ${hourList[index]} - $value")
152-
DefaultPoint(hourList[index], value.value.toFloat())
160+
XYGraph(
161+
xAxisModel = CategoryAxisModel(hourList),
162+
yAxisModel = rememberFloatLinearAxisModel(range = minGraph..maxGraph),
163+
xAxisContent = AxisContent(
164+
labels = { Text(it) },
165+
title = { Text("Hour") },
166+
style = AxisStyle(),
167+
),
168+
yAxisContent = AxisContent(
169+
labels = { Text(it.toString()) },
170+
title = { Text("Price") },
171+
style = AxisStyle(),
172+
),
173+
gridStyle = rememberGridStyle(),
174+
) {
175+
Chart(
176+
data = points,
177+
modifier = Modifier.fillMaxWidth(),
178+
)
153179
}
154-
// XYGraph(
155-
// xAxisModel = CategoryAxisModel(hourList),
156-
// yAxisModel = FloatLinearAxisModel(range = minGraph..maxGraph),
157-
// yAxisLabels = {
158-
// if (!thumbnail) {
159-
// AxisLabel(it.toString())
160-
// }
161-
// },
162-
// xAxisLabels = {
163-
// if (!thumbnail) {
164-
// AxisLabel(it, Modifier.padding(top = 2.dp))
165-
// }
166-
// }
167-
// )
168-
// XYGraph<String, Float>(
169-
// xAxisModel = CategoryAxisModel(hourList),
170-
// yAxisModel = FloatLinearAxisModel(range = minGraph..maxGraph),
171-
// ) {
172-
// val points = mapIndexed { index, value ->
173-
// if (value.value == minValue) {
174-
// hourMin = hourList[index]
175-
// }
176-
// if (value.value == maxValue) {
177-
// hourMax = hourList[index]
178-
// }
179-
// Logger.d("JAE ${hourList[index]} - $value")
180-
// DefaultPoint(hourList[index], value.value.toFloat())
181-
// }
182-
183-
// Chart(
184-
// data = points,
185-
// modifier = Modifier.fillMaxWidth(),
186-
// )
187-
// }
188180
}
189181
Text("Minimun prize: $minValue € at $hourMin")
190182
Text("Maximum prize: $maxValue € at $hourMax")
@@ -199,7 +191,7 @@ private fun XYGraphScope<String, Float>.Chart(
199191
data: List<DefaultPoint<String, Float>>,
200192
modifier: Modifier = Modifier,
201193
) {
202-
LinePlot(
194+
LinePlot2(
203195
data = data,
204196
modifier = modifier.fillMaxSize(),
205197
lineStyle = LineStyle(

modules/library-feature/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ plugins {
88
kotlin {
99
android {
1010
namespace = "com.jarroyo.library.feature"
11-
// resourcePrefix = "feature_" // Not supported in KotlinMultiplatformAndroidLibraryTarget
12-
// defaultConfig { // Not supported in KotlinMultiplatformAndroidLibraryTarget
13-
// consumerProguardFiles("$projectDir/proguard-feature-consumer-rules.pro")
14-
// }
1511
}
1612

1713
sourceSets {

modules/library-navigation-api/build.gradle.kts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,9 @@ plugins {
44

55

66
kotlin {
7-
android {
8-
namespace = "com.jarroyo.library.navigation.api"
9-
// resourcePrefix = "navigation_api_"
10-
// defaultConfig {
11-
// consumerProguardFiles("$projectDir/proguard-navigation-api-consumer-rules.pro")
12-
// }
13-
}
7+
android {
8+
namespace = "com.jarroyo.library.navigation.api"
9+
}
1410
sourceSets {
1511
commonMain.dependencies {
1612
implementation(libs.coroutines.core)

modules/library-navigation/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ plugins {
55
kotlin {
66
android {
77
namespace = "com.jarroyo.library.navigation"
8-
// resourcePrefix = "navigation_"
9-
// defaultConfig {
10-
// consumerProguardFiles("$projectDir/proguard-navigation-consumer-rules.pro")
11-
// }
128
}
139

1410
sourceSets {

0 commit comments

Comments
 (0)