Skip to content

Confusing comment on a JS branch instruction #37

Description

@ecm-pushbx

sectorlisp/sectorlisp.S

Lines 113 to 114 in fc6fa33

test %si,%si # set sf=1 if cons
js .PrintList # jump if not cons

This says:

  • "set sf=1 if cons"
  • js (jump if sign bit set)
  • "jump if not cons"

The js jump actually jumps if sf=1 so there is a contradiction here. I don't understand the code enough to determine which comment is wrong.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions