Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action ubuntu-patches fails on Noble #1986

Closed
psicho2000 opened this issue Jan 27, 2025 · 0 comments
Closed

GitHub Action ubuntu-patches fails on Noble #1986

psicho2000 opened this issue Jan 27, 2025 · 0 comments
Labels

Comments

@psicho2000
Copy link
Contributor

As of now, ubuntu-latest was upgraded to Ubuntu 24.04 (Noble) by GitHub: actions/runner-images#10636

This comes with version upgrades of clang and gcc.

As a result, the job make checkpatches fails:

1s
Run make checkpatches
./patches/check-patches.sh
O_COLEMAK=[1](https://github.com/jarun/nnn/actions/runs/12991833136/job/36230490252?pr=1985#step:3:1) O_GITSTATUS=0 O_NAMEFIRST=0 O_RESTOREPREVIEW=0 [FAILED]
O_COLEMAK=0 O_GITSTATUS=1 O_NAMEFIRST=0 O_RESTOREPREVIEW=0 [FAILED]
O_COLEMAK=1 O_GITSTATUS=1 O_NAMEFIRST=0 O_RESTOREPREVIEW=0 [FAILED]
O_COLEMAK=0 O_GITSTATUS=0 O_NAMEFIRST=1 O_RESTOREPREVIEW=0 [FAILED]
O_COLEMAK=1 O_GITSTATUS=0 O_NAMEFIRST=1 O_RESTOREPREVIEW=0 [FAILED]
O_COLEMAK=0 O_GITSTATUS=1 O_NAMEFIRST=1 O_RESTOREPREVIEW=0 [FAILED]
O_COLEMAK=1 O_GITSTATUS=1 O_NAMEFIRST=1 O_RESTOREPREVIEW=0 [FAILED]
O_COLEMAK=0 O_GITSTATUS=0 O_NAMEFIRST=0 O_RESTOREPREVIEW=1 [FAILED]
O_COLEMAK=1 O_GITSTATUS=0 O_NAMEFIRST=0 O_RESTOREPREVIEW=1 [FAILED]
O_COLEMAK=0 O_GITSTATUS=1 O_NAMEFIRST=0 O_RESTOREPREVIEW=1 [FAILED]
O_COLEMAK=1 O_GITSTATUS=1 O_NAMEFIRST=0 O_RESTOREPREVIEW=1 [FAILED]
O_COLEMAK=0 O_GITSTATUS=0 O_NAMEFIRST=1 O_RESTOREPREVIEW=1 [FAILED]
O_COLEMAK=1 O_GITSTATUS=0 O_NAMEFIRST=1 O_RESTOREPREVIEW=1 [FAILED]
O_COLEMAK=0 O_GITSTATUS=1 O_NAMEFIRST=1 O_RESTOREPREVIEW=1 [FAILED]
O_COLEMAK=1 O_GITSTATUS=1 O_NAMEFIRST=1 O_RESTOREPREVIEW=1 [FAILED]
make: *** [Makefile:340: checkpatches] Error 1
Error: Process completed with exit code 2.

If we dig deeper and unhide make's output from check-patches.sh in line 20, we see:
fatal error: readline/history.h: No such file or directory #include <readline/history.h>

Example run: https://github.com/psicho2000/nnn/actions/runs/12992602397/job/36232814898

Workaround:
Downgrade to Ubuntu-22.04 (Jammy) temporarily (see https://github.com/psicho2000/nnn/actions/runs/12992648283)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant