Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVS cannot recognize node as LTS/Gallium version #218

Closed
qcyblm opened this issue Oct 27, 2021 · 4 comments · Fixed by #231
Closed

NVS cannot recognize node as LTS/Gallium version #218

qcyblm opened this issue Oct 27, 2021 · 4 comments · Fixed by #231

Comments

@qcyblm
Copy link

qcyblm commented Oct 27, 2021

image
@danstur
Copy link

danstur commented Nov 4, 2021

I'm having the same problem - is there any workaround until this is fixed?

@Renari Renari mentioned this issue Mar 2, 2022
Closed
@Renari
Copy link

Renari commented Mar 2, 2022

I'm having the same problem - is there any workaround until this is fixed?

Seems to work if you use the full version number instead of the lts alias.

segevfiner added a commit to segevfiner/nvs that referenced this issue Mar 5, 2022
@segevfiner
Correctly wait on promisified cmdShim
e6efcde 
The internal cmd-shim module of npm has been promisified in
npm/cmd-shim@48fd811
(Version 4+ and above I think)

As such the callback was never invoked, and the promise never resolved,
leading to code after it to not run, such as the code to write the
version label to an `.nvs` file. This causes the issue in jasongin#218.

Fixes jasongin#218
@segevfiner segevfiner mentioned this issue Mar 5, 2022
Merged
@segevfiner
Copy link
Contributor

I believe I found the issue causing this: #231

segevfiner added a commit to segevfiner/nvs that referenced this issue Mar 5, 2022
@segevfiner
Correctly wait on promisified cmdShim
84aba70 
The internal cmd-shim module of npm has been promisified in
npm/cmd-shim@48fd811
(Version 4+ and above I think)

As such the callback was never invoked, and the promise never resolved,
leading to code after it to not run, such as the code to write the
version label to an `.nvs` file. This causes the issue in jasongin#218.

Fixes jasongin#218
segevfiner added a commit to segevfiner/nvs that referenced this issue Mar 5, 2022
@segevfiner
Correctly wait on promisified cmdShim
c93ba2a 
The internal cmd-shim module of npm has been promisified in
npm/cmd-shim@48fd811
(Version 4+ and above I think)

As such the callback was never invoked, and the promise never resolved,
leading to code after it to not run, such as the code to write the
version label to an `.nvs` file. This causes the issue in jasongin#218.

Fixes jasongin#218
jasongin pushed a commit that referenced this issue Mar 8, 2022
@segevfiner
Correctly wait on promisified cmdShim (#231)
64c7a64 
The internal cmd-shim module of npm has been promisified in
npm/cmd-shim@48fd811
(Version 4+ and above I think)

As such the callback was never invoked, and the promise never resolved,
leading to code after it to not run, such as the code to write the
version label to an `.nvs` file. This causes the issue in #218.

Fixes #218
@jasongin
Copy link
Owner

jasongin commented Mar 8, 2022

Fixed by #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly wait on promisified cmdShim segevfiner/nvs
5 participants
@Renari @jasongin @segevfiner @danstur @qcyblm