all: clean up vet errors

Author: aclements

cmd/branchstats/main.go

@@ -174,7 +174,7 @@ func main() {
 			pos = fmt.Sprintf("%s:%d", filepath.Base(sym.Line.File.Name), sym.Line.Line)
 			lines, _ = getLines(sym.Line.File.Name, sym.Line.Line-1, sym.Line.Line+1)
 		} else {
-			pos = fmt.Sprintf("%-24#x", pair.PC.PC)
+			pos = fmt.Sprintf("%#-24x", pair.PC.PC)
 			lines = nil
 		}
 

internal/cparse/vals.go

@@ -33,7 +33,7 @@ func (e *Extractor) Extract(env *BuildEnv) error {
 
 	// Construct printer program.
 	src := bytes.NewBufferString(e.Prologue)
-	fmt.Fprint(src, `
+	src.WriteString(`
 #include <stdio.h>
 #include <string.h>
 
@@ -60,7 +60,7 @@ int main(int argc, char **argv) {
 	for _, n := range e.Names {
 		fmt.Fprintf(src, "__CPARSE_PR(%s);\n", n)
 	}
-	fmt.Fprintf(src, "return 0;\n}\n")
+	src.WriteString("return 0;\n}\n")
 
 	// Compiler printer.
 	tdir, err := ioutil.TempDir("", "cparse-")

internal/gendefs/main.go

@@ -73,7 +73,7 @@ func process(path string) {
 		}
 		// Attach this decl.
 		if decl, ok := decl.(*ast.GenDecl); !ok || decl.Tok != token.CONST {
-			log.Fatalf("%s: def must be applied to const", defsTodo[0].Pos)
+			log.Fatalf("%s: def must be applied to const", fset.Position(defsTodo[0].Pos))
 		}
 		defsTodo[0].Decl = decl.(*ast.GenDecl)
 		defsTodo = defsTodo[1:]

perfsession/symbolize.go

@@ -315,7 +315,7 @@ func elfFuncTable(filename string, elff *elf.File) (out []funcRange, isReloc boo
 	syms, err := elff.Symbols()
 	if err != nil {
 		if err != elf.ErrNoSymbols {
-			log.Fatal("%s: %s", filename, err)
+			log.Fatalf("%s: %s", filename, err)
 		}
 		return nil, false
 	}