Skip to content

Commit 231ef3d

Browse files
committed
fix typo: option 3
1 parent 1b19996 commit 231ef3d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/jep/12049-type-annotations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ This may be purer from an OOP perspective, but it reintroduces a bifurcation and
292292

293293
##### Evaluation
294294

295-
There is no perfect option here, but weighing the pros and cons of these solutions, I (@jakevdp) believe that Option 4 presents the best path forward.
295+
There is no perfect option here, but weighing the pros and cons of these solutions, I (@jakevdp) believe that Option 3 presents the best path forward.
296296
It offers the least confusing API for users (`jax.Array` is the only object you need to worry about), and does not require any significant restructuring of our existing codepaths.
297297
There is one minor technical hurdle involved; that is that `jax.Array` will be defined in C++ via pybind11, and pybind11 currently [does not support](https://github.com/pybind/pybind11/issues/2696) custom metaclasses required for overriding `__instancecheck__`; nevertheless we should be able to work around this.
298298

0 commit comments

Comments
 (0)