Skip to content

Commit 5b9833a

Browse files
committed
Replace * by explicit column list
1 parent b1f0ce5 commit 5b9833a

File tree

6 files changed

+23
-12
lines changed

6 files changed

+23
-12
lines changed

src/main/celerio/angularjs/assets/js/applicationStates.p.vm.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ $output.webapp("assets\js", "applicationStates.js")##
1111
## str7: {{item.id.keyPart1}}:{{item.id.keyPart2}}
1212
## str8: {keyPart1: item.id.keyPart1, keyPart2: item.id.keyPart2}
1313
## str9: { "column1": true, "column2": true, ... }
14+
## str10: column1, column2, ...
1415
#########################################################################################
1516
##
16-
## Be careful: this method is call several times; be sure to change all calls when you add a parameter
17+
## Be careful: this method below is call several times; be sure to change all calls when you add a parameter
1718
## calls:
1819
## 3 inside this file
1920
## 1 in EntityController.e.vm.js
@@ -23,7 +24,7 @@ $output.webapp("assets\js", "applicationStates.js")##
2324
## 1 in EntityResource.e.vm.java
2425
##
2526
##
26-
#macro(generateSimpleOrCompositeKeyForURL $str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $list)
27+
#macro(generateSimpleOrCompositeKeyForURL $str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $list)
2728
#set ($compositeCall = false)
2829
#foreach ($attribute in $list)
2930
#if ($attribute.isInCpk() == true)
@@ -51,8 +52,10 @@ $output.webapp("assets\js", "applicationStates.js")##
5152

5253
#if ($str9 == "")
5354
#set ($str9 = "{ \"$attribute.name\": true")
55+
#set ($str10 = "$attribute.name")
5456
#else
5557
#set ($str9 = "$str9, \"$attribute.name\": true")
58+
#set ($str10 = "$str10, $attribute.name")
5659
#end
5760
#end
5861

@@ -121,7 +124,8 @@ app.config(function(${dollar}stateProvider, ${dollar}urlRouterProvider) {
121124
#set ($str7 = "")
122125
#set ($str8 = "")
123126
#set ($str9 = "")
124-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $entity.attributes.list)
127+
#set ($str10 = "")
128+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $entity.attributes.list)
125129
${dollar}stateProvider
126130
.state('$entity.name.toLowerCase()', {
127131
url: "/$entity.name.toLowerCase()",
@@ -153,7 +157,8 @@ app.config(function(${dollar}stateProvider, ${dollar}urlRouterProvider) {
153157
#set ($str7 = "")
154158
#set ($str8 = "")
155159
#set ($str9 = "")
156-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $entity.attributes.list)
160+
#set ($str10 = "")
161+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $entity.attributes.list)
157162
${dollar}stateProvider
158163
.state('edit${entity.name}', {
159164
url: "/${entity.name.toLowerCase()}/${str1}",
@@ -183,7 +188,8 @@ app.config(function(${dollar}stateProvider, ${dollar}urlRouterProvider) {
183188
#set ($str7 = "")
184189
#set ($str8 = "")
185190
#set ($str9 = "")
186-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $entity.attributes.list)
191+
#set ($str10 = "")
192+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $entity.attributes.list)
187193
${dollar}stateProvider
188194
.state('view${entity.name}', {
189195
url: "/${entity.name.toLowerCase()}/view/${str1}",

src/main/celerio/angularjs/assets/js/entity/EntityController.e.vm.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,8 @@ scope.${dollar}on("${dollar}destroy", function() {
452452
#set ($str7 = "")
453453
#set ($str8 = "")
454454
#set ($str9 = "")
455-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $entity.attributes.list)
455+
#set ($str10 = "")
456+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $entity.attributes.list)
456457
/** main REST client for managing (4 CRUD calls) ${entity.model.type} entity */
457458
app.factory('${entity.model.type}RestService', function (${dollar}resource) {
458459
return ${dollar}resource('api/${entity.model.vars}/bypage/?page=:page&size=:size', {}, {

src/main/celerio/angularjs/assets/js/entity/EntityEditController.e.vm.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ $output.webapp("assets\js\entity", "${entity.model.var}EditController.js")##
99
#set ($str7 = "")
1010
#set ($str8 = "")
1111
#set ($str9 = "")
12-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $entity.attributes.list)
12+
#set ($str10 = "")
13+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $entity.attributes.list)
1314

1415
app.controller("${entity.model.type}EditController", ["${dollar}scope", "${dollar}window", "${dollar}aside",
1516
"${dollar}log", "${entity.model.type}RestService",

src/main/celerio/angularjs/assets/tpl/apps/entity.e.vm.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
#set ($str7 = "")
1010
#set ($str8 = "")
1111
#set ($str9 = "")
12-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $entity.attributes.list)
12+
#set ($str10 = "")
13+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $entity.attributes.list)
1314

1415
<section>
1516
<div class="page-header">

src/main/celerio/springboot/src/main/java/domain/CompositePk.cpk.vm.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ public class $output.currentClass implements Comparable<$output.currentRootClass
4646
#set ($str7 = "")
4747
#set ($str8 = "")
4848
#set ($str9 = "")
49-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $primaryKey.entity.attributes.list)
49+
#set ($str10 = "")
50+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $primaryKey.entity.attributes.list)
5051
/**
5152
* Constructor with each part of the composite key as a parameter.
5253
*/

src/main/celerio/springboot/src/main/java/rest/EntityResource.e.vm.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ public class $output.currentClass{
143143
#set ($str7 = "")
144144
#set ($str8 = "")
145145
#set ($str9 = "")
146-
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $entity.attributes.list)
146+
#set ($str10 = "")
147+
#generateSimpleOrCompositeKeyForURL($str1 $str2 $str3 $str4 $str5 $str6 $str7 $str8 $str9 $str10 $entity.attributes.list)
147148
#if (($entity.hasSimplePk()))
148149
/**
149150
* Find by id $entity.model.type (for simple key).
@@ -375,15 +376,15 @@ public ResponseEntity<Boolean> exists($str3) throws URISyntaxException {
375376
/**
376377
* Search $entity.model.vars.
377378
*/
379+
// FIXME must return a Page like in method findAllByPage
378380
@RequestMapping(value = "/search",
379381
method = RequestMethod.POST,
380382
produces = MediaType.APPLICATION_JSON_VALUE)
381383
public ResponseEntity<List<$entity.model.type>> search(@RequestBody $entity.model.type $entity.model.var, Pageable pageable) throws URISyntaxException {
382384
log.debug("Search $entity.model.vars, page: " + pageable.getPageNumber() + ", size: " + pageable.getPageSize());
383385
log.debug("$entity.model.var: " + $entity.model.var);
384386
385-
// FIXME replace second * by column names
386-
String sqlMainPart = "select * from (select * from $entity.getTableName() where 1=1";
387+
String sqlMainPart = "select * from (select $str10 from $entity.getTableName() where 1=1";
387388
String sqlSecondaryPart = "";
388389
389390
List<Object> values = new ArrayList<Object>();

0 commit comments

Comments
 (0)