Skip to content

Commit f1a59fa

Browse files
committed
add test
1 parent cd2a0c3 commit f1a59fa

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

src/polymorphic/admin/inlines.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def get_child_inlines(self):
8484
This should return a list of tuples, exactly like
8585
:attr:`child_inlines` is.
8686
"""
87-
return self.child_inlines or ()
87+
return self.child_inlines or []
8888

8989
def get_child_inline_instances(self):
9090
"""

src/polymorphic/tests/admin.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from inspect import isclass
12
from django.contrib.admin import register, ModelAdmin, site as admin_site
23
from polymorphic.admin import (
34
StackedPolymorphicInline,
@@ -35,18 +36,22 @@ class PlainAAdmin(ModelAdmin):
3536
search_fields = ["field1"]
3637

3738

38-
class InlineModelAChild(StackedPolymorphicInline.Child):
39+
class Inline(StackedPolymorphicInline):
3940
model = InlineModelA
4041

42+
def get_child_inlines(self):
43+
return [
44+
child
45+
for child in self.__class__.__dict__.values()
46+
if isclass(child) and issubclass(child, StackedPolymorphicInline.Child)
47+
]
4148

42-
class InlineModelBChild(StackedPolymorphicInline.Child):
43-
model = InlineModelB
44-
autocomplete_fields = ["plain_a"]
45-
49+
class InlineModelAChild(StackedPolymorphicInline.Child):
50+
model = InlineModelA
4651

47-
class Inline(StackedPolymorphicInline):
48-
model = InlineModelA
49-
child_inlines = (InlineModelAChild, InlineModelBChild)
52+
class InlineModelBChild(StackedPolymorphicInline.Child):
53+
model = InlineModelB
54+
autocomplete_fields = ["plain_a"]
5055

5156

5257
@register(InlineParent)

0 commit comments

Comments
 (0)