Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding pipeitem/livepipeitem (or add text to edges) #443

Open
dberlin opened this issue Jan 8, 2025 · 0 comments
Open

Allow overriding pipeitem/livepipeitem (or add text to edges) #443

dberlin opened this issue Jan 8, 2025 · 0 comments

Comments

@dberlin
Copy link

dberlin commented Jan 8, 2025

Right now i have a fork where i've added support for adding text to edges (the annoying part being the transforms to properly rotate the text to match the rotating of the edge lines, without hitting the node direction indicator :P).

I do this right now as a direct edit of PipeItem.

Another way to do it would be allow for overriding the default pipe class that gets used when creating pipes.

i"m happy to work on a PR that does either -

  1. Add support for edge text annotations to the existing pipeitem class
    or
  2. Create a PipeItem factory that gets used to create PipeItems

I don't think it needs the full generality of node item factories, and happy to just add support for edge text instead.

Do you have a preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants