Skip to content

Commit 08e74d8

Browse files
Zoiazhidelev
Zoia
authored andcommitted
Remove hardcoded driver name in tests #7
1 parent e6ccf15 commit 08e74d8

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

JDI/web/selenium/elements/composite/web_site.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ def _init(site):
1010
WebCascadeInit().init_site_page(site)
1111

1212
@staticmethod
13-
def init(site, driver_name):
14-
WebSettings.use_driver(driver_name)
13+
def init(site):
14+
WebSettings.use_driver()
1515
WebCascadeInit().init_site_page(site)

JDI/web/selenium/settings/WebSettings.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ def set_driver_factory(driver_factory):
1717
JDISettings._driver_factory = driver_factory
1818

1919
@staticmethod
20-
def use_driver(driver_name, options=[], capabilities={}, executor=None):
20+
def use_driver(options=[], capabilities={}, executor=None):
21+
driver_name = JDISettings.get_setting_by_name('driver')
2122
JDISettings._driver_factory = SeleniumDriverFactory()
2223
WebSettings.set_driver_factory(JDISettings._driver_factory)
2324
return JDISettings._driver_factory.register_driver(driver_name, options, capabilities, executor)

JDI/web/selenium/settings/web_settings.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ def set_driver_factory(driver_factory):
1717
JDISettings._driver_factory = driver_factory
1818

1919
@staticmethod
20-
def use_driver(driver_name, options=[], capabilities={}, executor=None):
20+
def use_driver(options=[], capabilities={}, executor=None):
21+
driver_name = JDISettings.get_setting_by_name('driver')
2122
JDISettings._driver_factory = SeleniumDriverFactory()
2223
WebSettings.set_driver_factory(JDISettings._driver_factory)
2324
return JDISettings._driver_factory.register_driver(driver_name, options, capabilities, executor)

Test/jdi_uitest_web_examples/test/carrer_tests.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
class CareerTests(unittest.TestCase):
1313
@classmethod
1414
def setUpClass(cls):
15-
WebSite.init(EpamSite, "chrome")
15+
WebSite.init(EpamSite)
1616
WebSettings.logger.info("\nRun Tests from '%s' file" % cls.__name__)
1717

1818
def setUp(self):

Test/jdi_uitests_webtests/test/composite/page_tests.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
class PageTests(unittest.TestCase):
1414
def setUp(self):
1515
WebSettings.logger.info("Run Test %s" % self.id().split(".")[-1])
16-
WebSite.init(EpamJDISite, "chrome")
16+
WebSite.init(EpamJDISite)
1717
WebSettings.logger.info("Run Tests")
1818
EpamJDISite.home_page.open()
1919
EpamJDISite.login_page.submit(User.default())

Test/jdi_uitests_webtests/test/init_tests.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class InitTests(unittest.TestCase):
1111

1212
@classmethod
1313
def setUpClass(cls):
14-
WebSite.init(EpamJDISite, "chrome")
14+
WebSite.init(EpamJDISite)
1515
WebSettings.logger.info("\nRun Tests from '%s' file" % cls.__name__)
1616
EpamJDISite.home_page.open()
1717
EpamJDISite.login_page.submit(User.default())
@@ -31,7 +31,7 @@ class W3CInit(unittest.TestCase):
3131

3232
@classmethod
3333
def setUpClass(cls):
34-
WebSite.init(W3cSite, "chrome")
34+
WebSite.init(W3cSite)
3535
WebSettings.logger.info("Run Tests")
3636
W3cSite.frame_page.open()
3737

0 commit comments

Comments
 (0)