Skip to content

Commit 47751f0

Browse files
authored
add CONTRIBUTE.md file (#40)
* add CONTRIBUTING.md file * update chrome driver release * remove pypy builds
1 parent bba3187 commit 47751f0

File tree

3 files changed

+35
-5
lines changed

3 files changed

+35
-5
lines changed

Diff for: .github/workflows/jdi-python.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
runs-on: windows-latest
1616
strategy:
1717
matrix:
18-
python-version: ['3.7', '3.8', '3.x', 'pypy-3.7', 'pypy-3.7-nightly']
18+
python-version: ['3.7', '3.8', '3.x']
1919

2020
steps:
2121
- uses: actions/checkout@v2

Diff for: CONTRIBUTING.md

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Contributing to this repository
2+
3+
## Getting started
4+
5+
Before you begin:
6+
- Python 3.8 is used for this project.
7+
- For EPAM employees only: have you read the [Best Practices for Managing Secrets](https://elearn.epam.com/courses/course-v1:EPAM+5SCSS+0620/courseware/4b94c749c309409ea878fb7916be316b/ae4553f7cd524229b42f260b0ac692ed/1?activate_block_id=block-v1%3AEPAM%2B5SCSS%2B0620%2Btype%40vertical%2Bblock%40c04f1498c7d04ac4bf87b652741d90bb)?
8+
- Check out the [existing issues](https://github.com/jdi-testing/jdi-python/issues).
9+
10+
### Don't see your issue? Open one
11+
12+
Before you make your changes, check if an [issue already exists](https://github.com/jdi-testing/jdi-python/issues) for the change you want to make.
13+
14+
If you spot something new, [open an issue](https://github.com/jdi-testing/jdi-python/issues/new). We'll discuss the problem you want to fix.
15+
16+
When you're done making changes, open your PR and get it reviewed.
17+
18+
### Testing
19+
20+
In order to test the project, run pytest.
21+
22+
Please don't forget to set up the environment variable `TEST_PASSWORD`. For example:
23+
24+
For Windows `set TEST_PASSWORD=<password>`
25+
26+
```bash
27+
pytest <path to the project>/tests --no-header --no-summary -q
28+
```
29+
30+
You will be able to find log info in `<path to the project>/jdi.log`.

Diff for: tests/test_get_driver.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ def test_download_chromedriver(self):
1313
assert os.path.exists("chromedriver.exe") is True
1414

1515
def test_get_last_release(self):
16-
assert get_driver.get_last_release() == "89.0.4389.23"
16+
assert get_driver.get_last_release() == "90.0.4430.24"
1717

1818
def test_get_last_release_for_build(self):
19-
assert get_driver.get_last_release(build="87") == "87.0.4280.88"
19+
assert get_driver.get_last_release(build="90") == "90.0.4430.24"
2020

2121
def test_compose_driver_download_link(self):
2222
assert (
23-
get_driver.compose_download_link("89.0.4389.23")
24-
== "https://chromedriver.storage.googleapis.com/89.0.4389.23/chromedriver_win32.zip"
23+
get_driver.compose_download_link("90.0.4430.24")
24+
== "https://chromedriver.storage.googleapis.com/90.0.4430.24/chromedriver_win32.zip"
2525
)

0 commit comments

Comments
 (0)