Remove httpclient dependency (#476)

Co-authored-by: strangelookingnerd <[email protected]>

Author: strangelookingnerd

pom.xml

@@ -62,10 +62,6 @@
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>gitlab-api</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.jenkins-ci.plugins</groupId>
-      <artifactId>apache-httpcomponents-client-4-api</artifactId>
-    </dependency>
     <dependency>
       <groupId>org.jenkins-ci.plugins</groupId>
       <artifactId>branch-api</artifactId>

src/test/java/io/jenkins/plugins/gitlabserverconfig/servers/GitLabServerTest.java

@@ -7,7 +7,6 @@
 import static org.junit.Assert.assertEquals;
 
 import java.io.IOException;
-import org.apache.http.HttpStatus;
 import org.htmlunit.html.HtmlPage;
 import org.junit.ClassRule;
 import org.junit.Test;
@@ -79,8 +78,7 @@ public void testGetDoCheckServerUrl() throws IOException, SAXException {
             HtmlPage page = wc.goTo(
                     "descriptorByName/io.jenkins.plugins.gitlabserverconfig.servers.GitLabServer/checkServerUrl?serverUrl=http://attacker.example.com");
             assertEquals(
-                    HttpStatus.SC_NOT_FOUND,
-                    page.getWebResponse().getStatusCode()); // Should be 405 but Stapler doesn't work that way.
+                    404, page.getWebResponse().getStatusCode()); // Should be 405 but Stapler doesn't work that way.
         }
     }
 }