Skip to content

Commit 4034bb6

Browse files
authored
Change all default info logs to their respective levels (#64)
* Change all default info logs to their respective levels * Fix missing bracket * Update GitLabPipelineStatusNotifier.java * Delete .factorypath * Remove trailing space * Remove some unnecessary logs
1 parent c935134 commit 4034bb6

File tree

8 files changed

+114
-184
lines changed

8 files changed

+114
-184
lines changed

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabHookCreator.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ public static void register(SCMNavigatorOwner owner, GitLabSCMNavigator navigato
3636
}
3737
credentials = server.getCredentials();
3838
if (credentials == null) {
39-
LOGGER.info("No System credentials added, cannot create system hook");
39+
LOGGER.log(Level.WARNING, "No System credentials added, cannot create system hook");
4040
}
4141
break;
4242
case ITEM:
4343
credentials = navigator.credentials(owner);
4444
if (credentials == null) {
45-
LOGGER.info("No Item credentials added, cannot create system hook");
45+
LOGGER.log(Level.WARNING, "No Item credentials added, cannot create system hook");
4646
}
4747
break;
4848
default:
@@ -70,13 +70,13 @@ public static void register(GitLabSCMSource source,
7070
}
7171
credentials = server.getCredentials();
7272
if (credentials == null) {
73-
LOGGER.info("No System credentials added, cannot create web hook");
73+
LOGGER.log(Level.WARNING, "No System credentials added, cannot create web hook");
7474
}
7575
break;
7676
case ITEM:
7777
credentials = source.credentials();
7878
if (credentials == null) {
79-
LOGGER.info("No Item credentials added, cannot create web hook");
79+
LOGGER.log(Level.WARNING, "No Item credentials added, cannot create web hook");
8080
}
8181
break;
8282
default:
@@ -106,13 +106,13 @@ public static void register(GitLabSCMSource source,
106106
}
107107
credentials = server.getCredentials();
108108
if (credentials == null) {
109-
LOGGER.info("No System credentials added, cannot create system hook");
109+
LOGGER.log(Level.WARNING, "No System credentials added, cannot create system hook");
110110
}
111111
break;
112112
case ITEM:
113113
credentials = source.credentials();
114114
if (credentials == null) {
115-
LOGGER.info("No Item credentials added, cannot create system hook");
115+
LOGGER.log(Level.WARNING, "No Item credentials added, cannot create system hook");
116116
}
117117
break;
118118
default:

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabMergeRequestCommentTrigger.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void isMatch() {
3737
try (ACLContext ctx = ACL.as(ACL.SYSTEM)) {
3838
boolean jobFound = false;
3939
for (final SCMSourceOwner owner : SCMSourceOwners.all()) {
40-
LOGGER.info("Source Owner: " + owner.getFullDisplayName());
40+
LOGGER.log(Level.FINEST, String.format("Source Owner: %s", owner.getFullDisplayName()));
4141
// This is a hack to skip owners which are children of a SCMNavigator
4242
if (owner.getFullDisplayName().contains(" » ")) {
4343
continue;

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMNavigator.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ protected String id() {
221221
@Override
222222
public void visitSources(@NonNull final SCMSourceObserver observer)
223223
throws IOException, InterruptedException {
224-
LOGGER.info("visiting sources..");
225224
try (GitLabSCMNavigatorRequest request = new GitLabSCMNavigatorContext()
226225
.withTraits(traits)
227226
.newRequest(this, observer)) {
@@ -341,13 +340,13 @@ private PersonalAccessToken getWebHookCredentials(SCMSourceOwner owner) {
341340
}
342341
credentials = server.getCredentials();
343342
if (credentials == null) {
344-
LOGGER.info("No System credentials added, cannot create web hook");
343+
LOGGER.log(Level.WARNING, "No System credentials added, cannot create web hook");
345344
}
346345
break;
347346
case ITEM:
348347
credentials = credentials(owner);
349348
if (credentials == null) {
350-
LOGGER.info("No Item credentials added, cannot create web hook");
349+
LOGGER.log(Level.WARNING, "No Item credentials added, cannot create web hook");
351350
}
352351
break;
353352
default:
@@ -361,7 +360,6 @@ private PersonalAccessToken getWebHookCredentials(SCMSourceOwner owner) {
361360
protected List<Action> retrieveActions(@NonNull SCMNavigatorOwner owner,
362361
SCMNavigatorEvent event,
363362
@NonNull TaskListener listener) throws IOException, InterruptedException {
364-
LOGGER.info("retrieving actions..");
365363
getGitlabOwner();
366364
String fullName = gitlabOwner.getFullName();
367365
String webUrl = gitlabOwner.getWebUrl();
@@ -397,7 +395,6 @@ public void afterSave(@NonNull SCMNavigatorOwner owner) {
397395
GitLabSCMSourceContext ctx = new GitLabSCMSourceContext(null, SCMHeadObserver.none())
398396
.withTraits(navigatorContext.traits());
399397
GitLabHookRegistration systemhookMode = ctx.systemhookRegistration();
400-
LOGGER.info("Mode of system hook: " + systemhookMode.toString());
401398
GitLabHookCreator.register(owner, this, systemhookMode);
402399
}
403400

@@ -462,7 +459,6 @@ public String getIconFilePathPattern() {
462459

463460
@Override
464461
public SCMNavigator newInstance(String name) {
465-
LOGGER.info("Instantiating GitLabSCMNavigator..");
466462
GitLabSCMNavigator navigator =
467463
new GitLabSCMNavigator("");
468464
navigator.setTraits(getTraitsDefaults());

0 commit comments

Comments
 (0)