Add Invisible entry for project id (#83)

* Fetch project id in SCMSource constructor

* Add invisible entry to set project id in DescriptoImpl

* Remove number clazz from projectId textbox and instead modify getProjectId

* Use int over string

* Use StringUtils to check for empty strings

Co-authored-by: Joseph Petersen <[email protected]>

Author: baymac

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java

@@ -113,7 +113,7 @@ public class GitLabSCMSource extends AbstractGitSCMSource {
     private String sshRemote;
     private String httpRemote;
     private transient Project gitlabProject;
-    private int projectId = -1;
+    private int projectId;
 
     /**
      * The cache of {@link ObjectMetadataAction} instances for each open MR.
@@ -203,6 +203,7 @@ protected Project getGitlabProject(GitLabApi gitLabApi) {
                 gitlabProject = gitLabApi.getProjectApi().getProject(projectPath);
                 sshRemote = gitlabProject.getSshUrlToRepo();
                 httpRemote = gitlabProject.getHttpUrlToRepo();
+                projectId = gitlabProject.getId();
             } catch (GitLabApiException e) {
                 throw new IllegalStateException("Failed to retrieve project " + projectPath, e);
             }
@@ -219,7 +220,7 @@ public HashMap<String, AccessLevel> getMembers() {
                 members.put(m.getUsername(), m.getAccessLevel());
             }
         } catch (GitLabApiException e) {
-            LOGGER.log(Level.WARNING, "Exception caught:" + e, e);
+            LOGGER.log(Level.WARNING, "Exception while fetching members" + e, e);
             return new HashMap<>();
         }
         return members;
@@ -792,6 +793,27 @@ context, StandardUsernameCredentials.class, fromUri(getServerUrlFromName(serverN
             return result;
         }
 
+        public int getProjectId(@QueryParameter String projectPath, @QueryParameter String serverName) {
+            List<GitLabServer> gitLabServers = GitLabServers.get().getServers();
+            if (gitLabServers.size() == 0) {
+                return -1;
+            }
+            try {
+                GitLabApi gitLabApi;
+                if (StringUtils.isBlank(serverName)) {
+                    gitLabApi = apiBuilder(gitLabServers.get(0).getName());
+                } else {
+                    gitLabApi = apiBuilder(serverName);
+                }
+                if (StringUtils.isNotBlank(projectPath)) {
+                    return gitLabApi.getProjectApi().getProject(projectPath).getId();
+                }
+            } catch (GitLabApiException e) {
+                return -1;
+            }
+            return -1;
+        }
+
         public ListBoxModel doFillProjectPathItems(@AncestorInPath SCMSourceOwner context,
                 @QueryParameter String serverName, @QueryParameter String projectOwner) {
             List<GitLabServer> gitLabServers = GitLabServers.get().getServers();

src/main/resources/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource/config-detail.jelly

@@ -16,6 +16,9 @@
   <f:entry title="${%Behaviours}">
     <scm:traits field="traits"/>
   </f:entry>
+  <f:invisibleEntry>
+    <f:number clazz="project-id" field="projectId"/>
+  </f:invisibleEntry>
   <script>
     // var projectOwner = document.getElementsByClassName('project-owner');
     //