[JENKINS-57747] Add validation for GitLab Server Url, take two (#18)

* added server validation

* removed unused imports

* removed extra separation between imports

* removed extra line

* added a newline

Author: jetersen

src/main/java/io/jenkins/plugins/gitlabserverconfig/servers/GitLabServer.java

@@ -41,7 +41,6 @@
 /**
  * Represents a GitLab Server instance.
  */
-
 public class GitLabServer extends AbstractDescribableImpl<GitLabServer> {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(GitLabServer.class);
@@ -50,6 +49,7 @@ public class GitLabServer extends AbstractDescribableImpl<GitLabServer> {
      * Used as default server URL for the serverUrl field
      */
     public static final String GITLAB_SERVER_URL = "https://gitlab.com";
+
     /**
      * Used as default token value if no any credentials found by given credentialsId.
      */
@@ -220,15 +220,20 @@ public static FormValidation doCheckServerUrl(@QueryParameter String value) {
             try {
                 new URL(value);
             } catch (MalformedURLException e) {
-                LOGGER.error("Incorrect server url - %s", value);
-                return FormValidation.error("Malformed GitLab url (%s)", e.getMessage());
+                LOGGER.error("Incorrect url - %s", value);
+                return FormValidation.error("Malformed url (%s)", e.getMessage());
             }
-            // TODO:[JENKINS-57747] Add support for GitLab Ultimate (self hosted) and Gold (saas)
             if (GITLAB_SERVER_URL.equals(value)) {
-                LOGGER.info("Server URL is fine - %s", value);
+                LOGGER.info("Community version of GitLab - %s", value);
+            }
+            GitLabApi gitLabApi = new GitLabApi(value, "");
+            try {
+                gitLabApi.getProjectApi().getProjects(1, 1);
+                return FormValidation.ok();
+            } catch (GitLabApiException e) {
+                LOGGER.info("Unable to validate serverUrl - %s", value);
+                return FormValidation.error(Messages.GitLabServer_invalidUrl(value));
             }
-            LOGGER.info("Unable to validate serverUrl - %s", value);
-            return FormValidation.ok();
         }
 
         @NonNull

src/main/resources/io/jenkins/plugins/gitlabserverconfig/servers/Messages.properties

@@ -3,7 +3,7 @@ GitLabServer.displayName=GitLab Server
 GitLabServer.hookManagementAs=Hook management will be performed as <code>{0} </code>
 GitLabServer.validateInterrupted=Interrupted while trying to validate credentials
 GitLabServer.versionInterrupted=Interrupted while trying to determine server version
-GitLabServer.invalidUrl=Invalid URL: <code>{0}</code>
+GitLabServer.invalidUrl=Invalid GitLab Server URL: <code>{0}</code>
 GitLabServer.serverVersion=GitLab Version: <code>{0}</code>
 GitLabServer.failedValidation=Failed to validate the account <code>{0}</code>
 GitLabServer.credentialsNotResolved=Cannot resolve suitable credentials with id: <code>{0}</code>