Add mr contributor and metadata (#37)

* add mr contributor and metadata

* remove populating all owned projects for empty projectowner

* hashmaps -> concurrenthashmaps

Author: baymac

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java

@@ -35,6 +35,7 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Collectors;
 import jenkins.model.Jenkins;
 import jenkins.plugins.git.AbstractGitSCMSource;
@@ -54,6 +55,7 @@
 import jenkins.scm.api.SCMSourceDescriptor;
 import jenkins.scm.api.SCMSourceEvent;
 import jenkins.scm.api.SCMSourceOwner;
+import jenkins.scm.api.metadata.ContributorMetadataAction;
 import jenkins.scm.api.metadata.ObjectMetadataAction;
 import jenkins.scm.api.metadata.PrimaryInstanceMetadataAction;
 import jenkins.scm.api.mixin.ChangeRequestCheckoutStrategy;
@@ -111,6 +113,17 @@ public class GitLabSCMSource extends AbstractGitSCMSource {
     private transient Project gitlabProject;
     private int projectId = -1;
 
+    /**
+     * The cache of {@link ObjectMetadataAction} instances for each open MR.
+     */
+    @NonNull
+    private transient /*effectively final*/ Map<Integer,ObjectMetadataAction> mergeRequestMetadataCache = new ConcurrentHashMap<>();
+    /**
+     * The cache of {@link ObjectMetadataAction} instances for each open MR.
+     */
+    @NonNull
+    private transient /*effectively final*/ Map<Integer,ContributorMetadataAction> mergeRequestContributorCache = new ConcurrentHashMap<>();
+
     @DataBoundConstructor
     public GitLabSCMSource(String serverName, String projectOwner, String projectPath) {
         this.serverName = serverName;
@@ -354,6 +367,18 @@ public SCMSourceCriteria.Probe create(@NonNull BranchSCMHead head,
                         final MergeRequest m =
                             gitLabApi.getMergeRequestApi()
                                 .getMergeRequest(gitlabProject, mr.getIid());
+                        mergeRequestContributorCache.put(mr.getIid(),
+                            new ContributorMetadataAction(
+                                mr.getAuthor().getUsername(),
+                                mr.getAuthor().getName(),
+                                mr.getAuthor().getEmail()
+                            ));
+                        mergeRequestMetadataCache.put(mr.getIid(),
+                            new ObjectMetadataAction(
+                                mr.getTitle(),
+                                mr.getDescription(),
+                                mr.getWebUrl()
+                            ));
                         count++;
                         listener.getLogger().format("%nChecking merge request %s%n",
                             HyperlinkNote.encodeTo(
@@ -560,15 +585,21 @@ protected List<Action> retrieveActions(@NonNull SCMHead head, SCMHeadEvent event
                 result.add(new PrimaryInstanceMetadataAction());
             }
         } else if (head instanceof MergeRequestSCMHead) {
+            int iid = Integer.parseInt(((MergeRequestSCMHead) head).getId());
             String mergeUrl = mergeRequestUriTemplate(serverName)
                 .set("project", splitPath(projectPath))
-                .set("iid", ((MergeRequestSCMHead) head).getId())
+                .set("iid", iid)
                 .expand();
-            result.add(new ObjectMetadataAction(
-                null,
-                null,
-                mergeUrl
-            ));
+            ObjectMetadataAction metadataAction = mergeRequestMetadataCache.get(iid);
+            if (metadataAction == null) {
+                // best effort
+                metadataAction = new ObjectMetadataAction(null, null, mergeUrl);
+            }
+            result.add(metadataAction);
+            ContributorMetadataAction contributor = mergeRequestContributorCache.get(iid);
+            if (contributor != null) {
+                result.add(contributor);
+            }
             result.add(GitLabLink.toMergeRequest(mergeUrl));
         } else if (head instanceof GitLabTagSCMHead) {
             String tagUrl = tagUriTemplate(serverName)
@@ -806,9 +837,6 @@ public ListBoxModel doFillProjectPathItems(@AncestorInPath SCMSourceOwner contex
                 }
 
                 if (projectOwner.equals("")) {
-//                    for(Project p : gitLabApi.getProjectApi().getOwnedProjects()) {
-//                        result.add(p.getPathWithNamespace());
-//                    }
                     return new StandardListBoxModel().includeEmptyValue();
                 }
                 try {