Validate both username and password has value

before trying to use passwordAuth, ensure both are present.

An empty string leaves a valid Secret type, and login information seems
to stay from earlier plugin versions and has not been removed by the
plugin-upgrade-process.

This makes RundeckClientManager work-around the removed login
configuration which is no longer available in the plugin (as far as I
can see).

Author: norrs

src/main/java/org/jenkinsci/plugins/rundeck/client/RundeckClientManager.java

@@ -1,9 +1,11 @@
 package org.jenkinsci.plugins.rundeck.client;
 
+import com.google.common.annotations.VisibleForTesting;
 import hudson.AbortException;
 import okhttp3.ResponseBody;
 import org.jenkinsci.plugins.rundeck.RundeckInstance;
 import org.rundeck.client.RundeckClient;
+import org.rundeck.client.RundeckClient.Builder;
 import org.rundeck.client.api.RundeckApi;
 import org.rundeck.client.api.model.*;
 import org.rundeck.client.api.model.scheduler.ScheduledJobItem;
@@ -23,6 +25,8 @@ public class RundeckClientManager implements RundeckManager {
     private RundeckInstance rundeckInstance;
     private Client<RundeckApi> client;
 
+    private Builder<RundeckApi> clientBuilder;
+
     public RundeckClientManager() {
     }
 
@@ -31,6 +35,20 @@ public RundeckClientManager(RundeckInstance rundeckInstance) {
         buildClient();
     }
 
+
+    private Builder<RundeckApi> createRundeckClientBuilder() {
+        if (clientBuilder != null) {
+            return clientBuilder;
+        } else {
+            return RundeckClient.builder();
+        }
+    }
+
+    @VisibleForTesting
+    protected void setRundeckClientBuilder(Builder<RundeckApi> builder) {
+        clientBuilder = builder;
+    }
+
     public RundeckInstance getRundeckInstance() {
         return rundeckInstance;
     }
@@ -49,12 +67,13 @@ public void setClient(Client<RundeckApi> client) {
 
     public void buildClient(){
         if(client == null){
-            RundeckClient.Builder builder = RundeckClient.builder().baseUrl(rundeckInstance.getUrl());
+            RundeckClient.Builder builder = createRundeckClientBuilder().baseUrl(rundeckInstance.getUrl());
 
             if(rundeckInstance.getToken()!=null && !rundeckInstance.getToken().getPlainText().isEmpty()){
                 builder.tokenAuth(rundeckInstance.getToken().getPlainText());
             }
-            if(rundeckInstance.getLogin() != null && rundeckInstance.getPassword()!=null){
+            if (rundeckInstance.getLogin() != null && rundeckInstance.getPassword() != null
+                && !rundeckInstance.getPassword().getPlainText().isEmpty()) {
                 builder.passwordAuth(rundeckInstance.getLogin(),rundeckInstance.getPassword().getPlainText() );
             }