Always fuzzy search on Ctrl-?

[tamis-laan]

Right now when I press ctrl-? in lazygit I get the keybindings popup. What I normally do next is I search through the keybindings using / for the command I want to execute. But I find my self often forgetting to press the search command or I miss the key. Then when typing to search for the right command I will execute some git operation by accident.

Would it not be better to change ctrl-? directly to fuzzy search? This way it's easy to find the right command as a reference. It will still show the keybinding so one can learn how to use it. But only enter is used to execute the selected command from the list.

In fact I would love to just use fuzzy search for all operations because even in the interface I sometimes hit a random key causing something unexpected and often dangerous to happen. I'm always a bit nervous using lazygit.

[stefanhaller]

This makes sense; see also the PR description of #4880, which comes to a similar conclusion.

It's not trivial to do though; the naïve approach of simply entering search mode automatically (as if the user had pressed /) is not good enough, because:

• you'd have to press enter twice if you want to execute a command
• you'd have to press escape twice if you want to close the menu without doing anything
• if you want to move up and down the list using the arrow keys, you'd have to press enter first.

We'd have to extract the code from the filter prompt somehow so that we can build it into the menu directly (I guess we would still want to show the filter string in the status bar, just not move the keyboard focus there). I haven't looked at this in detail, but it feels like a pretty large amount of work to me.