From 3302a090f9189722e9d25b977c01e2b2c8c42fde Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Sun, 27 Apr 2025 10:48:43 +0200 Subject: [PATCH] Fix race condition when starting several command tasks in quick succession See https://github.com/jesseduffield/lazygit/issues/4507 for an elaborate description. --- pkg/tasks/tasks.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/tasks/tasks.go b/pkg/tasks/tasks.go index e20e5804533..bc56c5110eb 100644 --- a/pkg/tasks/tasks.go +++ b/pkg/tasks/tasks.go @@ -373,8 +373,6 @@ func (self *ViewBufferManager) NewTask(f func(TaskOpts) error, key string) error go utils.Safe(func() { defer completeGocuiTask() - self.readLines = nil - self.taskIDMutex.Lock() self.newTaskID++ taskID := self.newTaskID @@ -400,6 +398,8 @@ func (self *ViewBufferManager) NewTask(f func(TaskOpts) error, key string) error self.stopCurrentTask() } + self.readLines = nil + stop := make(chan struct{}) notifyStopped := make(chan struct{})