Fix copilot complaints

Co-authored-by: Copilot <[email protected]>

Author: IDisposable

display.go

@@ -75,7 +75,7 @@ func updateDisplay() {
 		nativeInstance.UpdateLabelIfChanged("hdmi_status_label", "Disconnected")
 		_, _ = nativeInstance.UIObjClearState("hdmi_status_label", "LV_STATE_CHECKED")
 	}
-	nativeInstance.UpdateLabelIfChanged("cloud_status_label", fmt.Sprintf("%d active", getActiveSessions()))
+	nativeInstance.UpdateLabelIfChanged("cloud_status_label", fmt.Sprintf("%d active", int(getActiveSessions())))
 
 	if networkManager != nil && networkManager.IsUp() {
 		nativeInstance.UISetVar("main_screen", "home_screen")

internal/usbgadget/hid_keyboard.go

@@ -199,7 +199,7 @@ func (u *UsbGadget) DelayAutoReleaseWithDuration(resetDuration time.Duration) {
 	}
 }
 
-// note: lock must be freeed by caller
+// note: lock must be freed by caller
 func (u *UsbGadget) popAutoReleaseTimer(key byte) bool {
 	u.kbdAutoReleaseLock.Lock()
 	timer, ok := u.kbdAutoReleaseTimers[key]

internal/usbgadget/usbgadget.go

@@ -170,12 +170,6 @@ func (u *UsbGadget) Close() error {
 	u.kbdAutoReleaseTimers = make(map[byte]*time.Timer)
 	u.kbdAutoReleaseLock.Unlock()
 
-	// Cancel keyboard state context
-	if u.keyboardStateCancel != nil {
-		u.keyboardStateCancel()
-		u.keyboardStateCancel = nil
-	}
-
 	// Close HID files
 	if u.keyboardHidFile != nil {
 		u.keyboardHidFile.Close()

ota.go

@@ -194,7 +194,7 @@ func rpcTryUpdateComponents(params updateParams, includePreRelease bool, resetCo
 
 func RunAutoUpdateCheck() {
 	// initially wait for 15 minutes before starting auto-update checks
-	// to avoid interfering with initial setup processesand to ensure
+	// to avoid interfering with initial setup processes and to ensure
 	// the system is stable before checking for updates
 	ticker := time.NewTicker(15 * time.Minute)
 	defer ticker.Stop()

usb_mass_storage.go

@@ -309,7 +309,7 @@ func initializeNBDDevice() error {
 	nbdDevice = NewNBDDevice()
 	if err := nbdDevice.Start(); err != nil {
 		logger.Warn().Err(err).Msg("failed to start nbd device")
-		return err
+		return fmt.Errorf("failed to set ndb device: %w", err)
 	}
 
 	logger.Debug().Msg("nbd device started")
@@ -318,7 +318,7 @@ func initializeNBDDevice() error {
 	time.Sleep(1 * time.Second)
 
 	if err := setMassStorageImage("/dev/nbd0"); err != nil {
-		return err
+		return fmt.Errorf("failed to set mass storage image to /dev/nbd0: %w", err)
 	}
 
 	logger.Info().Msg("usb mass storage mounted")
@@ -328,7 +328,7 @@ func initializeNBDDevice() error {
 func rpcMountWithStorage(filename string, mode VirtualMediaMode) error {
 	filename, err := sanitizeFilename(filename)
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to sanitize filename %s: %w", filename, err)
 	}
 
 	virtualMediaStateMutex.Lock()
@@ -341,15 +341,15 @@ func rpcMountWithStorage(filename string, mode VirtualMediaMode) error {
 	fullPath := filepath.Join(imagesFolder, filename)
 	fileInfo, err := os.Stat(fullPath)
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to get file info for %s: %w", fullPath, err)
 	}
 
 	if err := setMassStorageMode(mode == CDROM); err != nil {
-		return err
+		return fmt.Errorf("failed to set mass storage mode %s: %w", mode, err)
 	}
 
 	if err := setMassStorageImage(fullPath); err != nil {
-		return err
+		return fmt.Errorf("failed to set mass storage image to %s: %w", fullPath, err)
 	}
 	currentVirtualMediaState = &VirtualMediaState{
 		Source:   Storage,
@@ -434,18 +434,18 @@ func sanitizeFilename(filename string) (string, error) {
 func rpcDeleteStorageFile(filename string) error {
 	sanitizedFilename, err := sanitizeFilename(filename)
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to sanitize filename %s: %w", filename, err)
 	}
 
 	fullPath := filepath.Join(imagesFolder, sanitizedFilename)
 
 	if _, err := os.Stat(fullPath); os.IsNotExist(err) {
-		return fmt.Errorf("file does not exist: %s", filename)
+		return fmt.Errorf("file %s does not exist: %w", fullPath, err)
 	}
 
 	err = os.Remove(fullPath)
 	if err != nil {
-		return fmt.Errorf("failed to delete file: %w", err)
+		return fmt.Errorf("failed to delete file %s: %w", fullPath, err)
 	}
 
 	return nil
@@ -461,7 +461,7 @@ const uploadIdPrefix = "upload_"
 func rpcStartStorageFileUpload(filename string, size int64) (*StorageFileUpload, error) {
 	sanitizedFilename, err := sanitizeFilename(filename)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to sanitize filename %s: %w", filename, err)
 	}
 
 	filePath := path.Join(imagesFolder, sanitizedFilename)
@@ -479,7 +479,7 @@ func rpcStartStorageFileUpload(filename string, size int64) (*StorageFileUpload,
 	uploadId := uploadIdPrefix + uuid.New().String()
 	file, err := os.OpenFile(uploadPath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
 	if err != nil {
-		return nil, fmt.Errorf("failed to open file for upload: %v", err)
+		return nil, fmt.Errorf("failed to open file %s for upload: %w", uploadPath, err)
 	}
 	pendingUploadsMutex.Lock()
 	pendingUploads[uploadId] = pendingUpload{