1) EDI doc 2) add ignore_crlf to edi schema 3) add default to edi schema 4) make edi err msg more useful 5) fix cli.sh (#129)

1) EDI doc 2) add `ignore_crlf` to edi schema 3) add `default` to edi schema 4) make edi err msg more useful 5) fix cli.sh

Author: jf-tech

cli.sh

@@ -1,9 +1,9 @@
 #!/bin/bash
 CUR_DIR=$(pwd)
-SCRIPT_DIR=$(dirname "$0")
-cd $SCRIPT_DIR && \
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd -P)"
+cd "$SCRIPT_DIR" && \
   go build \
-    -o $CUR_DIR/op \
+    -o "$CUR_DIR/op" \
     -ldflags "-X main.gitCommit=$(git rev-parse HEAD) -X main.buildEpochSec=$(date +%s)" \
-    $SCRIPT_DIR/cli/op.go
-cd $CUR_DIR && ./op "$@"
+    "$SCRIPT_DIR/cli/op.go"
+cd "$CUR_DIR" && ./op "$@"

cli/cmd/transformCmd.go

@@ -22,7 +22,11 @@ var (
 		Short: "Transforms input to desired output based on a schema.",
 		Args:  cobra.NoArgs,
 		RunE: func(cmd *cobra.Command, _ []string) error {
-			return doTransform()
+			if err := doTransform(); err != nil {
+				fmt.Println() // to sure cobra cli always write out "Error: ..." on a new line.
+				return err
+			}
+			return nil
 		},
 	}
 	schema string

doc/edi_in_depth.md

@@ -1,4 +1,4 @@
 {
 	"Records": null,
-	"FinalErr": "input 'test' between character [1,6]: missing segment name"
+	"FinalErr": "input 'test' at segment no.1 (char[1,6]): missing segment name"
 }

doc/resources/edi_comp_delim.png

@@ -1,4 +1,4 @@
 {
 	"Records": null,
-	"FinalErr": "input 'test' between character [1,7]: unable to find element 'e2' on segment ''"
+	"FinalErr": "input 'test' at segment no.1 (char[1,7]): unable to find element 'e2' on segment ''"
 }

doc/resources/edi_seg_structure.png

@@ -2,5 +2,5 @@
 	"Records": [
 		"{'e1':'0','e2':'1','e3':'2'}"
 	],
-	"FinalErr": "input 'test' between character [11,11]: segment 'IEA' needs min occur 1, but only got 0"
+	"FinalErr": "input 'test' at segment no.3 (char[11,11]): segment 'IEA' needs min occur 1, but only got 0"
 }

extensions/omniv21/fileformat/edi/.snapshots/TestRead-missing_raw_seg_name,_failure

@@ -1,4 +1,4 @@
 {
 	"Records": null,
-	"FinalErr": "input 'test' between character [7,7]: segment 'ISA' needs min occur 1, but only got 0"
+	"FinalErr": "input 'test' at segment no.1 (char[7,7]): segment 'ISA' needs min occur 1, but only got 0"
 }

extensions/omniv21/fileformat/edi/.snapshots/TestRead-raw_seg_processing_wrong,_failure

@@ -1,7 +1,7 @@
 {
 	"Records": [
 		"{'e1':'0','e2':'1','e3':'2'}",
-		"{'e1':'3','e2':'','e3':''}"
+		"{'e1':'3','e2':'','e3':'x'}"
 	],
 	"FinalErr": "EOF"
 }