APP-4230 - Add E2E test for --skip-unassigned flag

Two subtests covering auto-promotion behavior:
- Success: source repo mapped to DEV -> version promoted to DEV
- Mismatch: source repo mapped only to PROD -> version stays unassigned
  with message explaining the repo_mismatch

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: danielreJfrog

apptrust/commands/version/create_app_version_cmd_test.go

@@ -139,7 +139,6 @@ func TestCreateAppVersionCommand_FlagsSuite(t *testing.T) {
 				ctx.Arguments = []string{"app-key", "1.0.0"}
 				ctx.AddStringFlag(commands.TagFlag, "release-tag")
 				ctx.AddBoolFlag(commands.DraftFlag, true)
-				ctx.AddBoolFlag(commands.SkipUnassignedFlag, true)
 				ctx.AddStringFlag(commands.SourceTypeBuildsFlag, "name=build1,id=1.0.0,include-deps=true,repo-key=build-info-repo,started=2024-01-15T10:30:00Z;name=build2,id=2.0.0,include-deps=false")
 				ctx.AddStringFlag(commands.SourceTypeReleaseBundlesFlag, "name=rb1,version=1.0.0;name=rb2,version=2.0.0")
 				ctx.AddStringFlag(commands.SourceTypeApplicationVersionsFlag, "application-key=source-app,version=3.2.1")
@@ -151,7 +150,6 @@ func TestCreateAppVersionCommand_FlagsSuite(t *testing.T) {
 				Version:        "1.0.0",
 				Tag:            "release-tag",
 				Draft:          true,
-				SkipUnassigned: true,
 				Sources: &model.CreateVersionSources{
 					Builds: []model.CreateVersionBuild{
 						{Name: "build1", Number: "1.0.0", IncludeDependencies: true, RepositoryKey: "build-info-repo", Started: "2024-01-15T10:30:00Z"},

e2e/utils/artifactory_utils.go

@@ -210,3 +210,22 @@ func deleteBuild() {
 		log.Error("Failed to delete build-info", err)
 	}
 }
+
+func CreateLocalRepo(t *testing.T, suffix string, environments []string) string {
+	servicesManager := getArtifactoryServicesManager(t)
+	repoKey := GetTestProjectKey(t) + "-" + suffix
+	localRepoConfig := services.NewGenericLocalRepositoryParams()
+	localRepoConfig.ProjectKey = GetTestProjectKey(t)
+	localRepoConfig.Key = repoKey
+	localRepoConfig.Environments = environments
+	err := servicesManager.CreateLocalRepository().Generic(localRepoConfig)
+	require.NoError(t, err)
+	t.Cleanup(func() {
+		_ = servicesManager.DeleteRepository(repoKey)
+	})
+	return repoKey
+}
+
+func UploadTestArtifact(t *testing.T, repoKey, fileName string) string {
+	return uploadSimpleFileToArtifactory(t, repoKey, fileName)
+}

e2e/version_test.go

@@ -196,6 +196,70 @@ func TestCreateVersion_Draft(t *testing.T) {
 	assert.Equal(t, utils.StatusDraft, versionContent.Status)
 }
 
+func TestCreateVersion_SkipUnassigned(t *testing.T) {
+	appKey := utils.GenerateUniqueKey("app-version-skip-unassigned")
+	utils.CreateBasicApplication(t, appKey)
+	defer utils.DeleteApplication(t, appKey)
+
+	testPackage := utils.GetTestPackage(t)
+
+	t.Run("passes eligibility when source repo is mapped to first stage", func(t *testing.T) {
+		version := utils.GenerateUniqueKey("skip-ua-ok")
+
+		packageFlag := fmt.Sprintf("--source-type-packages=type=%s, name=%s, version=%s, repo-key=%s",
+			testPackage.PackageType, testPackage.PackageName, testPackage.PackageVersion, testPackage.RepoKey)
+		output := utils.AppTrustCli.RunCliCmdWithOutput(t, "version-create", appKey, version, packageFlag, "--skip-unassigned")
+		defer utils.DeleteApplicationVersion(t, appKey, version)
+
+		require.NotEmpty(t, output)
+
+		var response struct {
+			ApplicationKey string `json:"application_key"`
+			Version        string `json:"version"`
+			Status         string `json:"status"`
+			CurrentStage   string `json:"current_stage"`
+			Message        string `json:"message"`
+		}
+		err := json.Unmarshal([]byte(output), &response)
+		require.NoError(t, err, "failed to parse CLI output as JSON: %s", output)
+		assert.Equal(t, appKey, response.ApplicationKey)
+		assert.Equal(t, version, response.Version)
+
+		versionContent, statusCode, err := utils.GetApplicationVersion(appKey, version)
+		require.NoError(t, err)
+		assert.Equal(t, http.StatusOK, statusCode)
+		require.NotNil(t, versionContent)
+		assert.Equal(t, utils.StatusCompleted, versionContent.Status)
+		assert.Equal(t, "DEV", versionContent.CurrentStage, "Version should be auto-promoted to DEV stage")
+	})
+
+	t.Run("stays unassigned with message when artifacts mismatch first stage", func(t *testing.T) {
+		version := utils.GenerateUniqueKey("skip-ua-fail")
+
+		prodRepo := utils.CreateLocalRepo(t, "prod-only-local", []string{"PROD"})
+		artifactPath := utils.UploadTestArtifact(t, prodRepo, "mismatch-artifact.txt")
+		artifactFlag := fmt.Sprintf("--source-type-artifacts=path=%s", artifactPath)
+		output := utils.AppTrustCli.RunCliCmdWithOutput(t, "version-create", appKey, version, artifactFlag, "--skip-unassigned")
+		defer utils.DeleteApplicationVersion(t, appKey, version)
+
+		require.NotEmpty(t, output)
+
+		var response struct {
+			ApplicationKey string `json:"application_key"`
+			Version        string `json:"version"`
+			Status         string `json:"status"`
+			CurrentStage   string `json:"current_stage"`
+			Message        string `json:"message"`
+		}
+		err := json.Unmarshal([]byte(output), &response)
+		require.NoError(t, err, "failed to parse CLI output as JSON: %s", output)
+		assert.Equal(t, appKey, response.ApplicationKey)
+		assert.Equal(t, version, response.Version)
+		assert.Empty(t, response.CurrentStage, "Version should NOT be promoted when artifacts are in PROD-only repo")
+		assert.NotEmpty(t, response.Message, "A message should explain why auto-promotion did not occur")
+	})
+}
+
 func TestCreateVersion_Async(t *testing.T) {
 	appKey := utils.GenerateUniqueKey("app-version-create-async")
 	utils.CreateBasicApplication(t, appKey)