refactor(alpine): remove manual [ERROR]/[WARN]/[HINT] prefixes, use log library levels

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: naveenku-jfrog

artifactory/commands/alpine/apkcommand.go

@@ -1,6 +1,7 @@
 package alpine
 
 import (
+	"errors"
 	"fmt"
 	"net/url"
 	"os"
@@ -98,7 +99,8 @@ func (apkCmd *ApkCommand) ServerDetails() (*config.ServerDetails, error) {
 func (apkCmd *ApkCommand) Run() error {
 	apkPath, err := exec.LookPath("apk")
 	if err != nil {
-		return fmt.Errorf("[ERROR] 'apk' binary not found. Is this an Alpine Linux environment?")
+		log.Error("'apk' binary not found. Is this an Alpine Linux environment?")
+		return errors.New("'apk' binary not found. Is this an Alpine Linux environment?")
 	}
 
 	needsAuth := buildInfoSubcmds[apkCmd.commandName] || authOnlySubcmds[apkCmd.commandName]
@@ -113,7 +115,7 @@ func (apkCmd *ApkCommand) Run() error {
 	if needsBuildInfo {
 		preSnapshot, err = biUtils.ListInstalledPackages()
 		if err != nil {
-			log.Warn("[WARN] Cannot list installed packages — Build Info not captured:", err)
+			log.Warn("Cannot list installed packages — Build Info not captured:", err)
 			needsBuildInfo = false
 		}
 	}
@@ -127,7 +129,7 @@ func (apkCmd *ApkCommand) Run() error {
 	if needsBuildInfo {
 		cacheDir, err = io.CreateTempDir()
 		if err != nil {
-			log.Warn("[WARN] Could not create temp cache dir — checksums may be incomplete:", err)
+			log.Warn("Could not create temp cache dir — checksums may be incomplete:", err)
 		} else {
 			defer func() { _ = os.RemoveAll(cacheDir) }()
 		}
@@ -161,10 +163,9 @@ func (apkCmd *ApkCommand) buildSubprocessEnv(injectAuth bool) ([]string, error)
 
 	if apkCmd.serverDetails == nil {
 		if apkCmd.username != "" || apkCmd.password != "" {
-			log.Warn("[WARN] --user/--password provided but no server URL is known. " +
-				"Use --server-id to select a configured server so HTTP_AUTH can be injected.")
+			log.Warn("--user/--password provided but no server URL is known. Use --server-id to select a configured server so HTTP_AUTH can be injected.")
 		} else {
-			log.Warn("[WARN] No JFrog server configured — skipping HTTP_AUTH injection. Run: jf c add")
+			log.Warn("No JFrog server configured — skipping HTTP_AUTH injection. Run: jf c add")
 		}
 		return env, nil
 	}
@@ -218,7 +219,7 @@ func emitSignatureHint(exitErr *exec.ExitError) {
 	}
 	for _, pattern := range sigPatterns {
 		if strings.Contains(stderr, pattern) {
-			log.Warn("[HINT] Signature verification failed. Fix: jf apk config --server-id <id> --repo <repo> --apply")
+			log.Warn("Signature verification failed. Fix: jf apk config --server-id <id> --repo <repo> --apply")
 			return
 		}
 	}
@@ -239,7 +240,7 @@ func (apkCmd *ApkCommand) collectBuildInfo(preSnapshot []biUtils.AlpinePackage,
 
 	buildObj, err := buildUtils.PrepareBuildPrerequisites(apkCmd.buildConfiguration)
 	if err != nil {
-		log.Warn("[WARN] Build Info publish failed:", err)
+		log.Warn("Build Info publish failed:", err)
 		return nil
 	}
 
@@ -252,7 +253,7 @@ func (apkCmd *ApkCommand) collectBuildInfo(preSnapshot []biUtils.AlpinePackage,
 	alpineModule.SetCacheDir(cacheDir)
 
 	if err := alpineModule.CollectBuildInfo(); err != nil {
-		log.Warn("[WARN] Build Info publish failed:", err)
+		log.Warn("Build Info collection failed:", err)
 	}
 	return nil
 }

artifactory/commands/alpine/apkconfig.go

@@ -115,7 +115,7 @@ func (apkCmd *ApkConfigCommand) Run() error {
 // downloadRSAKey fetches the RSA public key from the Artifactory keypair API.
 func downloadRSAKey(endpoint string, creds resolvedCredentials) (string, error) {
 	if creds.Username == "" && creds.Password == "" {
-		return "", fmt.Errorf("[ERROR] No credentials found for this server. Run: jf c add")
+		return "", fmt.Errorf("no credentials found for this server. Run: jf c add")
 	}
 
 	req, err := http.NewRequest(http.MethodGet, endpoint, nil)
@@ -133,11 +133,11 @@ func downloadRSAKey(endpoint string, creds resolvedCredentials) (string, error)
 	switch resp.StatusCode {
 	case http.StatusOK:
 	case http.StatusNotFound:
-		return "", fmt.Errorf("[WARN] No RSA key configured for %q. Use --allow-untrusted or configure a signing key in Artifactory", endpoint)
+		return "", fmt.Errorf("no RSA key configured for %q. Use --allow-untrusted or configure a signing key in Artifactory", endpoint)
 	case http.StatusUnauthorized:
-		return "", fmt.Errorf("[ERROR] Access token expired or invalid. Run: jf c add")
+		return "", fmt.Errorf("access token expired or invalid. Run: jf c add")
 	case http.StatusForbidden:
-		return "", fmt.Errorf("[ERROR] Access token lacks read permission on the repository")
+		return "", fmt.Errorf("access token lacks read permission on the repository")
 	default:
 		return "", fmt.Errorf("unexpected HTTP %d from Artifactory RSA key endpoint", resp.StatusCode)
 	}

artifactory/commands/alpine/apkupload.go

@@ -129,7 +129,7 @@ func (apkCmd *ApkUploadCommand) Run() error {
 	log.Info("Upload successful.")
 
 	if err := apkCmd.setProperties(target, pkgName, pkgVersion, arch); err != nil {
-		log.Warn("[WARN] Failed to set artifact properties:", err)
+		log.Warn("Failed to set artifact properties:", err)
 	}
 
 	collectBuildInfo, err := apkCmd.buildConfiguration.IsCollectBuildInfo()
@@ -138,7 +138,7 @@ func (apkCmd *ApkUploadCommand) Run() error {
 	}
 	if collectBuildInfo {
 		if err := apkCmd.recordBuildInfoArtifact(filename, pkgName, pkgVersion, arch, fileDetails.Checksum); err != nil {
-			log.Warn("[WARN] Build Info artifact recording failed:", err)
+			log.Warn("Build Info artifact recording failed:", err)
 		}
 	}
 	return nil
@@ -173,11 +173,11 @@ func (apkCmd *ApkUploadCommand) uploadFile(uploadURL string, creds resolvedCrede
 	case http.StatusCreated, http.StatusOK:
 		return nil
 	case http.StatusUnauthorized:
-		return fmt.Errorf("[ERROR] Access token expired or invalid. Run: jf c add")
+		return fmt.Errorf("access token expired or invalid. Run: jf c add")
 	case http.StatusForbidden:
-		return fmt.Errorf("[ERROR] Insufficient permissions to deploy to repository %q", apkCmd.repoKey)
+		return fmt.Errorf("insufficient permissions to deploy to repository %q", apkCmd.repoKey)
 	case http.StatusConflict:
-		return fmt.Errorf("[ERROR] Artifact already exists at the target path (repo policy blocks overwrite)")
+		return fmt.Errorf("artifact already exists at the target path (repo policy blocks overwrite)")
 	default:
 		body, _ := io.ReadAll(resp.Body)
 		return fmt.Errorf("upload failed with HTTP %d: %s", resp.StatusCode, string(body))