docker_test.go

package main

import (
	"context"
	"errors"
	"fmt"
	"net/url"
	"os"
	"os/exec"
	"path"
	"path/filepath"
	"strconv"
	"strings"
	"testing"
	"time"

	"github.com/jfrog/jfrog-client-go/utils/log"
	urfavecli "github.com/urfave/cli"

	tests2 "github.com/jfrog/jfrog-cli-artifactory/utils/tests"

	"github.com/moby/moby/api/types/mount"

	biutils "github.com/jfrog/build-info-go/utils"

	"github.com/jfrog/build-info-go/entities"
	"github.com/jfrog/gofrog/version"
	coreContainer "github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/container"
	"github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/generic"
	container "github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/ocicontainer"
	"github.com/jfrog/jfrog-cli-core/v2/artifactory/utils"
	"github.com/jfrog/jfrog-cli-core/v2/common/build"
	"github.com/jfrog/jfrog-cli-core/v2/common/spec"
	"github.com/jfrog/jfrog-cli-core/v2/utils/coreutils"
	coreTests "github.com/jfrog/jfrog-cli-core/v2/utils/tests"
	"github.com/jfrog/jfrog-cli/inttestutils"
	"github.com/jfrog/jfrog-cli/utils/tests"
	"github.com/jfrog/jfrog-client-go/auth"
	clientUtils "github.com/jfrog/jfrog-client-go/utils"
	"github.com/jfrog/jfrog-client-go/utils/io/fileutils"
	clientTestUtils "github.com/jfrog/jfrog-client-go/utils/tests"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
	"github.com/testcontainers/testcontainers-go/wait"
)

const (
	kanikoImage = "gcr.io/kaniko-project/executor:latest"
	rtNetwork   = "test-network"
)

func InitContainerTests() {
	initArtifactoryCli()
	cleanUpOldBuilds()
	inttestutils.CleanUpOldImages(serverDetails)
	cleanUpOldRepositories()
	tests.AddTimestampToGlobalVars()
	createRequiredRepos()
}

func initContainerTest(t *testing.T) (containerManagers []container.ContainerManagerType) {
	if *tests.TestDocker {
		containerManagers = append(containerManagers, container.DockerClient)
	}
	if *tests.TestPodman {
		containerManagers = append(containerManagers, container.Podman)
	}
	if len(containerManagers) == 0 {
		t.Skip("Skipping docker and podman tests.")
	}
	return containerManagers
}

func initNativeDockerWithArtTest(t *testing.T) func() {
	if !*tests.TestDocker {
		t.Skip("Skipping native docker test. To run docker test add the '-test.docker=true' option.")
	}
	oldHomeDir := os.Getenv(coreutils.HomeDir)
	servicesManager, err := utils.CreateServiceManager(serverDetails, -1, 0, false)
	require.NoError(t, err)
	rtVersion, err := servicesManager.GetVersion()
	require.NoError(t, err)
	if !version.NewVersion(rtVersion).AtLeast(coreContainer.MinRtVersionForRepoFetching) {
		t.Skip("Skipping native docker test. Artifactory version " + coreContainer.MinRtVersionForRepoFetching + " or higher is required (actual is'" + rtVersion + "').")
	}
	// Create server config to use with the command.
	createJfrogHomeConfig(t, true)
	return func() {
		clientTestUtils.SetEnvAndAssert(t, coreutils.HomeDir, oldHomeDir)
	}
}

// initDockerBuildTest initializes test environment for docker build tests with JFROG_RUN_NATIVE enabled
func initDockerBuildTest(t *testing.T) func() {
	// Set JFROG_RUN_NATIVE=true for docker build tests
	clientTestUtils.SetEnvAndAssert(t, "JFROG_RUN_NATIVE", "true")

	// Initialize native docker test setup
	cleanupNativeDocker := initNativeDockerWithArtTest(t)

	// if this is an external JFrog instance, no need to setup buildx with insecure registry
	if strings.HasPrefix(*tests.JfrogUrl, "https://") {
		return func() {
			// Restore JFROG_RUN_NATIVE
			clientTestUtils.UnSetEnvAndAssert(t, "JFROG_RUN_NATIVE")
			// Run native docker cleanup
			cleanupNativeDocker()
		}
	}
	// Setup buildx builder with insecure registry config for localhost
	builderName := "jfrog-test-builder"
	cleanupBuilder := setupInsecureBuildxBuilder(t, builderName)

	// Return combined cleanup function
	return func() {
		// Cleanup buildx builder
		cleanupBuilder()
		// Restore JFROG_RUN_NATIVE
		clientTestUtils.UnSetEnvAndAssert(t, "JFROG_RUN_NATIVE")
		// Run native docker cleanup
		cleanupNativeDocker()
	}
}

// setupInsecureBuildxBuilder creates a buildx builder with insecure registry config
func setupInsecureBuildxBuilder(t *testing.T, builderName string) func() {
	// Get registry host from ContainerRegistry
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}

	// Create temporary buildkitd.toml config
	tmpDir, err := os.MkdirTemp("", "buildkit-config")
	require.NoError(t, err)

	configPath := filepath.Join(tmpDir, "buildkitd.toml")
	configContent := fmt.Sprintf(`[registry."%s"]
  http = true
  insecure = true
`, registryHost)
	require.NoError(t, os.WriteFile(configPath, []byte(configContent), 0644)) //#nosec G703 -- test code, path is constructed from temp dir

	// Remove builder if it exists (stop first, then remove)
	_ = exec.Command("docker", "buildx", "stop", builderName).Run()
	_ = exec.Command("docker", "buildx", "rm", "-f", builderName).Run()

	// Also remove any leftover buildkit container
	_ = exec.Command("docker", "rm", "-f", "buildx_buildkit_"+builderName+"0").Run()

	// Create buildx builder with insecure config
	// Pin to moby/buildkit:v0.12.2 as v0.12.3+ has issues with private HTTP insecure registries
	createCmd := exec.Command("docker", "buildx", "create",
		"--name", builderName,
		"--driver", "docker-container",
		"--driver-opt", "network=host",
		"--driver-opt", "image=moby/buildkit:v0.12.2",
		"--config", configPath,
		"--bootstrap",
		"--use")
	output, err := createCmd.CombinedOutput()
	require.NoError(t, err, "Failed to create buildx builder: %s", string(output))

	// Verify builder is using our config
	inspectCmd := exec.Command("docker", "buildx", "inspect", builderName)
	output, err = inspectCmd.CombinedOutput()
	require.NoError(t, err, "Failed to inspect buildx builder: %s", string(output))
	log.Info("Builder inspect output: %s", string(output))

	// Set BUILDX_BUILDER env var to force 'docker build' to use our builder
	oldBuilder := os.Getenv("BUILDX_BUILDER")
	require.NoError(t, os.Setenv("BUILDX_BUILDER", builderName))

	log.Info("Created buildx builder '%s' with insecure registry config for '%s'", builderName, registryHost)

	// Return cleanup function
	return func() {
		// Restore original BUILDX_BUILDER env var
		if oldBuilder == "" {
			_ = os.Unsetenv("BUILDX_BUILDER")
		} else {
			_ = os.Setenv("BUILDX_BUILDER", oldBuilder)
		}
		// Remove the builder
		_ = exec.Command("docker", "buildx", "rm", builderName).Run()
		// Cleanup temp directory
		_ = os.RemoveAll(tmpDir)
	}
}

func TestContainerPush(t *testing.T) {
	containerManagers := initContainerTest(t)
	for _, repo := range []string{tests.DockerLocalRepo, tests.DockerVirtualRepo} {
		for _, containerManager := range containerManagers {
			runPushTest(containerManager, tests.DockerImageName, tests.DockerImageName+":1", false, t, repo)
		}
	}
}

func TestContainerPushWithModuleName(t *testing.T) {
	containerManagers := initContainerTest(t)
	for _, repo := range []string{tests.DockerLocalRepo, tests.DockerVirtualRepo} {
		for _, containerManager := range containerManagers {
			runPushTest(containerManager, tests.DockerImageName, ModuleNameJFrogTest, true, t, repo)
		}
	}
}

func TestContainerPushWithDetailedSummary(t *testing.T) {
	containerManagers := initContainerTest(t)
	for _, containerManager := range containerManagers {
		imageName := tests.DockerImageName
		module := tests.DockerImageName + ":1"
		buildNumber := "1"
		for _, repo := range []string{tests.DockerLocalRepo, tests.DockerVirtualRepo} {
			func() {
				imageTag, err := inttestutils.BuildTestImage(imageName+":1", "", repo, containerManager)
				assert.NoError(t, err)
				defer tests2.DeleteTestImage(t, imageTag, containerManager)
				// Testing detailed summary without build-info
				pushCommand := coreContainer.NewPushCommand(containerManager)
				pushCommand.SetThreads(1).SetDetailedSummary(true).SetCmdParams([]string{"push", imageTag}).SetBuildConfiguration(new(build.BuildConfiguration)).SetRepo(tests.DockerLocalRepo).SetServerDetails(serverDetails).SetImageTag(imageTag)
				assert.NoError(t, pushCommand.Run())
				result := pushCommand.Result()
				reader := result.Reader()
				defer readerCloseAndAssert(t, reader)
				readerGetErrorAndAssert(t, reader)
				for transferDetails := new(clientUtils.FileTransferDetails); reader.NextRecord(transferDetails) == nil; transferDetails = new(clientUtils.FileTransferDetails) {
					assert.Equal(t, 64, len(transferDetails.Sha256), "Summary validation failed - invalid sha256 has returned from artifactory")
				}
				// Testing detailed summary with build-info
				pushCommand.SetBuildConfiguration(build.NewBuildConfiguration(tests.DockerBuildName, buildNumber, "", ""))
				assert.NoError(t, pushCommand.Run())
				anotherResult := pushCommand.Result()
				anotherReader := anotherResult.Reader()
				defer readerCloseAndAssert(t, anotherReader)

				readerGetErrorAndAssert(t, anotherReader)
				for transferDetails := new(clientUtils.FileTransferDetails); anotherReader.NextRecord(transferDetails) == nil; transferDetails = new(clientUtils.FileTransferDetails) {
					assert.Equal(t, 64, len(transferDetails.Sha256), "Summary validation failed - invalid sha256 has returned from artifactory")
				}

				inttestutils.ValidateGeneratedBuildInfoModule(t, tests.DockerBuildName, buildNumber, "", []string{module}, entities.Docker)
				runRt(t, "build-publish", tests.DockerBuildName, buildNumber)

				imagePath := path.Join(repo, imageName, "1") + "/"
				validateContainerBuild(tests.DockerBuildName, buildNumber, imagePath, module, 7, 5, t)

				// Check deployment view
				assertPrintedDeploymentViewFunc, cleanupFunc := initDeploymentViewTest(t)
				defer cleanupFunc()
				runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-push", pushCommand.ImageTag(), tests.DockerLocalRepo))
				assertPrintedDeploymentViewFunc()
				inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, imageName, tests.DockerBuildName, repo)
			}()
		}
	}
}

func TestContainerPushWithMultipleSlash(t *testing.T) {
	containerManagers := initContainerTest(t)
	for _, repo := range []string{tests.DockerLocalRepo, tests.DockerVirtualRepo} {
		for _, containerManager := range containerManagers {
			runPushTest(containerManager, tests.DockerImageName+"/multiple", "multiple:1", false, t, repo)
		}
	}
}

// TestContainerSkipImageIdVerification re-runs the existing container
// push, pull, and buildx (which is also a push) flows with
// JFROG_CLI_SKIP_DOCKER_IMAGE_ID_VERIFICATION=true to prove build-info is
// still collected correctly when users opt into the skip escape hatch. The
// default path (verify, with WithFileBufferedOpener) is already covered by
// the same underlying tests running without the env var. Pull must ignore
// the skip env and always verify — this test also guards that contract.
func TestContainerSkipImageIdVerification(t *testing.T) {
	initContainerTest(t)
	clientTestUtils.SetEnvAndAssert(t, container.SkipDockerImageIdVerificationEnv, "true")
	defer clientTestUtils.UnSetEnvAndAssert(t, container.SkipDockerImageIdVerificationEnv)

	t.Run("push", TestContainerPush)
	t.Run("pull", TestContainerPull)
	t.Run("buildx", TestDockerBuildxWithBuildInfo)
}

func runPushTest(containerManager container.ContainerManagerType, imageName, module string, withModule bool, t *testing.T, repo string) {
	imageTag, err := inttestutils.BuildTestImage(imageName+":1", "", repo, containerManager)
	assert.NoError(t, err)
	defer tests2.DeleteTestImage(t, imageTag, containerManager)
	buildNumber := "1"

	if withModule {
		runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-push", imageTag, repo, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber, "--module="+module))
	} else {
		runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-push", imageTag, repo, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber))
	}
	defer inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, imageName, tests.DockerBuildName, repo)

	inttestutils.ValidateGeneratedBuildInfoModule(t, tests.DockerBuildName, buildNumber, "", []string{module}, entities.Docker)
	runRt(t, "build-publish", tests.DockerBuildName, buildNumber)

	imagePath := path.Join(repo, imageName, "1") + "/"
	validateContainerBuild(tests.DockerBuildName, buildNumber, imagePath, module, 7, 5, t)
}

func loginToArtifactory(t *testing.T, container *tests.TestContainer) {
	password := *tests.JfrogPassword
	user := *tests.JfrogUser
	if *tests.JfrogAccessToken != "" {
		user = auth.ExtractUsernameFromAccessToken(*tests.JfrogAccessToken)
		password = *tests.JfrogAccessToken
	}
	assert.NoError(t, container.Exec(
		context.Background(),
		"docker",
		"login",
		tests.RtContainerHostName,
		"--username="+user,
		"--password="+password,
	))
}

func buildBuilderImage(t *testing.T, workspace, dockerfile, containerName string) *tests.TestContainer {
	ctx := context.Background()
	testContainer, err := tests.NewContainerRequest().
		SetDockerfile(workspace, dockerfile, nil).
		Privileged().
		Networks(rtNetwork).
		Name(containerName).
		Mount(mount.Mount{Type: mount.TypeBind, Source: workspace, Target: "/workspace", ReadOnly: false}).
		Cmd("--insecure-registry", tests.RtContainerHostName).
		WaitFor(wait.ForLog("API listen on /var/run/docker.sock").WithStartupTimeout(5*time.Minute)).
		Remove().
		Build(ctx, true)
	assert.NoError(t, err, "Couldn't create builder image.")
	return testContainer
}

// This test validate the collect build-info flow for fat-manifest images.
// The way we build the fat manifest and push it to Artifactory is not important.
// Therefore, this test runs only with docker.
func TestPushFatManifestImage(t *testing.T) {
	t.Skip("Skipping until JGC-483 is fixed")
	if !*tests.TestDocker {
		t.Skip("Skipping test. To run it, add the '-test.docker=true' option.")
	}
	buildName := "push-fat-manifest" + tests.DockerBuildName

	// Create temp test dir.
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))
	testDataDir := filepath.Join(filepath.FromSlash(tests.GetTestResourcesPath()), "docker")
	files, err := os.ReadDir(testDataDir)
	assert.NoError(t, err)
	for _, file := range files {
		if !file.IsDir() {
			_, err := tests.ReplaceTemplateVariables(filepath.Join(testDataDir, file.Name()), tests.Out)
			assert.NoError(t, err)
		}
	}

	// Build the builder image locally.
	testContainer := buildBuilderImage(t, workspace, "Dockerfile.Buildx.Fatmanifest", "buildx_container")
	defer func() { assert.NoError(t, testContainer.Terminate(context.Background())) }()

	// Enable the builder util in the container.
	err = testContainer.Exec(context.Background(), "sh", "script.sh")
	assert.NoError(t, err)

	// Login to Artifactory
	loginToArtifactory(t, testContainer)

	buildxOutputFile := "buildmetadata"

	// Run the builder in the container and push the fat-manifest image to Artifactory
	assert.NoError(t, testContainer.Exec(
		context.Background(),
		"docker",
		"buildx",
		"build",
		"--platform",
		"linux/amd64,linux/arm64,linux/arm/v7",
		"--tag", path.Join(tests.RtContainerHostName,
			tests.DockerLocalRepo,
			tests.DockerImageName+"-multiarch-image"),
		"-f",
		"Dockerfile.Fatmanifest",
		"--metadata-file",
		"/workspace/"+buildxOutputFile,
		"--push",
		".",
	))

	// Run 'build-docker-create' & publish the results to Artifactory.
	buildxOutput := filepath.Join(workspace, buildxOutputFile)
	buildNumber := "1"
	assert.NoError(t, artifactoryCli.Exec("build-docker-create", tests.DockerLocalRepo, "--image-file="+buildxOutput, "--build-name="+buildName, "--build-number="+buildNumber))
	assert.NoError(t, artifactoryCli.Exec("build-publish", buildName, buildNumber))

	// Validate the published build-info exists
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
	assert.NoError(t, err)
	assert.True(t, found, "build info was expected to be found")
	assert.True(t, len(publishedBuildInfo.BuildInfo.Modules) > 1)

	// Validate build-name & build-number properties in all image layers
	searchSpec := spec.NewBuilder().Pattern(tests.DockerLocalRepo + "/*").Build(buildName).Recursive(true).BuildSpec()
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpec)
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	totalResults, err := reader.Length()
	assert.NoError(t, err)
	assert.True(t, totalResults > 1)
}

// runNestedPathDockerBuildTest is a helper function for testing docker build --push with nested paths.
// It handles common setup, build execution, validation, and cleanup.
// platforms: empty string for single platform, or comma-separated platforms like "linux/amd64,linux/arm64"
func runNestedPathDockerBuildTest(t *testing.T, buildNameSuffix, imageSuffix, nestedPath, platforms string) {
	buildName := buildNameSuffix + tests.DockerBuildName
	buildNumber := "1"

	// Extract hostname from ContainerRegistry (remove protocol if present)
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}

	// Construct image name with nested path: repo/nestedPath/image
	nestedImageName := path.Join(registryHost, tests.OciLocalRepo, nestedPath, imageSuffix)
	imageTag := nestedImageName + ":v1"

	// Create test workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Construct base image with hostname
	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "alpine:latest")

	// Create Dockerfile
	dockerfileContent := fmt.Sprintf(`FROM %s
RUN echo "Built for nested path test"
CMD ["echo", "Hello from nested path"]`, baseImage)

	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code, path built from test workspace

	// Cleanup old build
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
	defer inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)

	// Clean build before test
	runJfrogCli(t, "rt", "bc", buildName, buildNumber)

	// Run docker build --push (single or multiplatform based on platforms parameter)
	if platforms != "" {
		runJfrogCli(t, "docker", "buildx", "build", "--platform", platforms,
			"-t", imageTag, "-f", dockerfilePath, "--push", "--build-name="+buildName, "--build-number="+buildNumber, workspace)
	} else {
		runJfrogCli(t, "docker", "build", "-t", imageTag, "-f", dockerfilePath, "--push",
			"--build-name="+buildName, "--build-number="+buildNumber, workspace)
	}

	// Publish build info
	runJfrogCli(t, "rt", "build-publish", buildName, buildNumber)

	// Validate the published build-info exists
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
	assert.NoError(t, err)
	assert.True(t, found, "build info was expected to be found")
	assert.True(t, len(publishedBuildInfo.BuildInfo.Modules) >= 1, "Expected at least 1 module in build info")

	// Validate build-name & build-number properties in all image layers at nested path
	searchSpec := spec.NewBuilder().Pattern(tests.OciLocalRepo + "/" + nestedPath + "/*").Build(buildName).Recursive(true).BuildSpec()
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpec)
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	totalResults, err := reader.Length()
	assert.NoError(t, err)
	assert.True(t, totalResults > 1, "Expected layers to be found at nested path "+nestedPath+"/")

	// Cleanup image from Artifactory
	inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, nestedPath+"/"+imageSuffix, buildName, tests.OciLocalRepo)
}

// TestDockerBuildPushWithNestedPath tests docker build --push with nested paths like repo/myorg/image.
// This validates that layer fetching works correctly for single platform images with nested paths.
func TestDockerBuildPushWithNestedPath(t *testing.T) {
	t.Skip("Skipping until JGC-483 is fixed")
	cleanup := initDockerBuildTest(t)
	defer cleanup()
	runNestedPathDockerBuildTest(t, "docker-build-nested", "test-single-nested", "myorg", "")
}

// TestPushFatManifestImageWithNestedPath tests pushing fat-manifest (multi-platform) images with nested paths.
// This validates that layer fetching works correctly for paths like <repository>/myorg/image
// which was failing before the fix to FatManifestHandler.createSearchablePathForDockerManifestContents.
func TestPushFatManifestImageWithNestedPath(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()
	runNestedPathDockerBuildTest(t, "push-fat-manifest-nested", "test-multiarch-nested", "myorg", "linux/amd64,linux/arm64")
}

// TestDockerBuildWithNestedPathBaseImage tests that dependencies are correctly collected
// when using a nested path image as a base layer in a Dockerfile.
func TestDockerBuildWithNestedPathBaseImage(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	// Extract hostname from ContainerRegistry
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}

	// Step 1: Push a base image to a nested path (myorg/base-image)
	baseImageBuildName := "base-nested" + tests.DockerBuildName
	baseImageBuildNumber := "1"
	nestedBasePath := "myorg"
	baseImageName := path.Join(registryHost, tests.OciLocalRepo, nestedBasePath, "base-image")
	baseImageTag := baseImageName + ":v1"

	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Create base Dockerfile
	alpineBase := path.Join(registryHost, tests.OciRemoteRepo, "alpine:latest")
	baseDockerfile := fmt.Sprintf(`FROM %s
RUN echo "This is the nested base image"
CMD ["echo", "base"]`, alpineBase)

	baseDockerfilePath := filepath.Join(workspace, "Dockerfile.base")
	assert.NoError(t, os.WriteFile(baseDockerfilePath, []byte(baseDockerfile), 0644)) //#nosec G703 -- test code, path built from test workspace

	// Push base image to nested path
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, baseImageBuildName, artHttpDetails)
	defer inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, baseImageBuildName, artHttpDetails)

	runJfrogCli(t, "rt", "bc", baseImageBuildName, baseImageBuildNumber)
	runJfrogCli(t, "docker", "build", "-t", baseImageTag, "-f", baseDockerfilePath, "--push",
		"--build-name="+baseImageBuildName, "--build-number="+baseImageBuildNumber, workspace)
	runJfrogCli(t, "rt", "build-publish", baseImageBuildName, baseImageBuildNumber)

	// Step 2: Build a new image using the nested path base image
	childBuildName := "child-nested" + tests.DockerBuildName
	childBuildNumber := "1"
	childImageName := path.Join(registryHost, tests.OciLocalRepo, "child-image")
	childImageTag := childImageName + ":v1"

	// Create child Dockerfile that uses the nested path base image
	childDockerfile := fmt.Sprintf(`FROM %s
RUN echo "This is the child image using nested base"
CMD ["echo", "child"]`, baseImageTag)

	childDockerfilePath := filepath.Join(workspace, "Dockerfile.child")
	assert.NoError(t, os.WriteFile(childDockerfilePath, []byte(childDockerfile), 0644)) //#nosec G703 -- test code, path built from test workspace

	// Build child image
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, childBuildName, artHttpDetails)
	defer inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, childBuildName, artHttpDetails)

	runJfrogCli(t, "rt", "bc", childBuildName, childBuildNumber)
	runJfrogCli(t, "docker", "build", "-t", childImageTag, "-f", childDockerfilePath, "--push",
		"--build-name="+childBuildName, "--build-number="+childBuildNumber, workspace)
	runJfrogCli(t, "rt", "build-publish", childBuildName, childBuildNumber)

	// Step 3: Validate build info has dependencies from the nested path base image
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, childBuildName, childBuildNumber)
	assert.NoError(t, err)
	assert.True(t, found, "build info was expected to be found")
	assert.True(t, len(publishedBuildInfo.BuildInfo.Modules) >= 1, "Expected at least 1 module in build info")

	// Check that dependencies exist (these come from the base image layers)
	module := publishedBuildInfo.BuildInfo.Modules[0]
	assert.True(t, len(module.Dependencies) > 0,
		"Expected dependencies from nested path base image (myorg/base-image). ")

	// Cleanup
	inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, nestedBasePath+"/base-image", baseImageBuildName, tests.OciLocalRepo)
	inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, "child-image", childBuildName, tests.OciLocalRepo)
}

func TestPushMultiTaggedImage(t *testing.T) {
	if !*tests.TestDocker {
		t.Skip("Skipping test. To run it, add the '-test.docker=true' option.")
	}

	buildName := "push-multi-tagged" + tests.DockerBuildName
	buildNumber := "1"

	// Setup workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))
	testDataDir := filepath.Join(filepath.FromSlash(tests.GetTestResourcesPath()), "docker")
	files, err := os.ReadDir(testDataDir)
	assert.NoError(t, err)
	for _, file := range files {
		if !file.IsDir() {
			_, err := tests.ReplaceTemplateVariables(filepath.Join(testDataDir, file.Name()), tests.Out)
			assert.NoError(t, err)
		}
	}

	// Build the builder image locally
	testContainer := buildBuilderImage(t, workspace, "Dockerfile.Buildx.Fatmanifest", "buildx_multi_tag_container")
	defer func() { assert.NoError(t, testContainer.Terminate(context.Background())) }()

	// Enable builder
	assert.NoError(t, testContainer.Exec(context.Background(), "sh", "script.sh"))

	// Login to Artifactory
	loginToArtifactory(t, testContainer)

	// Build & push image with multiple tags
	imageName1 := path.Join(tests.RtContainerHostName, tests.DockerLocalRepo, tests.DockerImageName+"-multi:v1")
	imageName2 := path.Join(tests.RtContainerHostName, tests.DockerLocalRepo, tests.DockerImageName+"-multi:latest")
	buildxOutputFile := "multi-build-metadata"

	assert.NoError(t, testContainer.Exec(
		context.Background(),
		"docker", "buildx", "build",
		"--platform", "linux/amd64,linux/arm64",
		"-t", imageName1,
		"-t", imageName2,
		"-f", "Dockerfile.Fatmanifest",
		"--metadata-file", "/workspace/"+buildxOutputFile,
		"--push", ".",
	))

	// Run build-docker-create & publish
	buildxOutput := filepath.Join(workspace, buildxOutputFile)
	assert.NoError(t, artifactoryCli.Exec("build-docker-create", tests.DockerLocalRepo, "--image-file="+buildxOutput, "--build-name="+buildName, "--build-number="+buildNumber))
	assert.NoError(t, artifactoryCli.Exec("build-publish", buildName, buildNumber))

	// Validate build-info is published
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
	assert.NoError(t, err)
	assert.True(t, found, "build info was expected to be found")
	assert.True(t, len(publishedBuildInfo.BuildInfo.Modules) >= 1)

	// Validate build-name & build-number properties in all layers
	searchSpec := spec.NewBuilder().Pattern(tests.DockerLocalRepo + "/*").Build(buildName).Recursive(true).BuildSpec()
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpec)
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	totalResults, err := reader.Length()
	assert.NoError(t, err)
	assert.True(t, totalResults > 1)
}

func TestContainerPushBuildNameNumberFromEnv(t *testing.T) {
	containerManagers := initContainerTest(t)
	for _, containerManager := range containerManagers {
		func() {
			imageTag, err := inttestutils.BuildTestImage(tests.DockerImageName+":1", "", tests.DockerLocalRepo, containerManager)
			assert.NoError(t, err)
			defer tests2.DeleteTestImage(t, imageTag, containerManager)
			buildNumber := "1"
			setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.BuildName, tests.DockerBuildName)
			defer setEnvCallBack()
			setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.BuildNumber, buildNumber)
			defer setEnvCallBack()
			// Push container image
			runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-push", imageTag, tests.DockerLocalRepo))
			runRt(t, "build-publish")

			imagePath := path.Join(tests.DockerLocalRepo, tests.DockerImageName, "1") + "/"
			validateContainerBuild(tests.DockerBuildName, buildNumber, imagePath, tests.DockerImageName+":1", 7, 5, t)
			inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, tests.DockerImageName, tests.DockerBuildName, tests.DockerLocalRepo)
		}()
	}
}

func TestContainerPull(t *testing.T) {
	containerManagers := initContainerTest(t)
	for _, containerManager := range containerManagers {
		func() {
			imageName, err := inttestutils.BuildTestImage(tests.DockerImageName+":1", "", tests.DockerLocalRepo, containerManager)
			assert.NoError(t, err)
			defer tests2.DeleteTestImage(t, imageName, containerManager)
			for _, repo := range []string{tests.DockerVirtualRepo, tests.DockerLocalRepo} {

				// Push container image
				runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-push", imageName, repo))
				buildNumber := "1"

				// Pull container image
				runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-pull", imageName, repo, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber))
				runRt(t, "build-publish", tests.DockerBuildName, buildNumber)

				imagePath := path.Join(repo, tests.DockerImageName, "1") + "/"
				validateContainerBuild(tests.DockerBuildName, buildNumber, imagePath, tests.DockerImageName+":1", 0, 7, t)

				buildNumber = "2"
				runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-pull", imageName, repo, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber, "--module="+ModuleNameJFrogTest))
				runRt(t, "build-publish", tests.DockerBuildName, buildNumber)
				validateContainerBuild(tests.DockerBuildName, buildNumber, imagePath, ModuleNameJFrogTest, 0, 7, t)

				inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, tests.DockerImageName, tests.DockerBuildName, repo)
			}
		}()
	}
}

func TestDockerClientApiVersionCmd(t *testing.T) {
	initContainerTest(t)
	// Assert docker min API version
	assert.NoError(t, container.ValidateClientApiVersion())
}

func TestContainerFatManifestPull(t *testing.T) {
	containerManagers := initContainerTest(t)
	for _, containerManager := range containerManagers {
		imageName := "traefik"
		buildNumber := "1"
		for _, dockerRepo := range [...]string{tests.DockerRemoteRepo, tests.DockerVirtualRepo} {
			func() {
				// Pull container image
				imageTag := path.Join(*tests.ContainerRegistry, dockerRepo, imageName+":2.2")
				defer tests2.DeleteTestImage(t, imageTag, containerManager)
				runCmdWithRetries(t, jfrogRtCliTask(containerManager.String()+"-pull", imageTag, dockerRepo, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber))
				runRt(t, "build-publish", tests.DockerBuildName, buildNumber)

				// Validate
				publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, tests.DockerBuildName, buildNumber)
				if err != nil {
					assert.NoError(t, err)
					return
				}
				if !found {
					assert.True(t, found, "build info was expected to be found")
					return
				}
				buildInfo := publishedBuildInfo.BuildInfo
				validateBuildInfo(buildInfo, t, 6, 0, imageName+":2.2", entities.Docker)

				inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.DockerBuildName, artHttpDetails)
			}()
		}
	}
}

func TestDockerPromote(t *testing.T) {
	initContainerTest(t)

	// Build and push image
	imageName, err := inttestutils.BuildTestImage(tests.DockerImageName+":1", "", tests.DockerLocalRepo, container.DockerClient)
	assert.NoError(t, err)
	defer tests2.DeleteTestImage(t, imageName, container.DockerClient)

	// Push image
	runCmdWithRetries(t, jfrogRtCliTask("docker-push", imageName, tests.DockerLocalRepo))
	assert.NoError(t, err)

	// Promote image
	runRt(t, "docker-promote", tests.DockerImageName, tests.DockerLocalRepo, tests.DockerLocalPromoteRepo, "--source-tag=1", "--target-tag=2", "--target-docker-image="+tests.DockerImageName+"promotion", "--copy")
	defer inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, tests.DockerImageName, tests.DockerBuildName, tests.DockerLocalRepo)

	// Verify image in source
	imagePath := path.Join(tests.DockerLocalRepo, tests.DockerImageName, "1") + "/"
	validateContainerImage(t, imagePath, 7)

	// Verify image promoted
	searchSpec, err := tests.CreateSpec(tests.SearchPromotedDocker)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetDockerDeployedManifest(), searchSpec, serverDetails, t)
}

func validateContainerBuild(buildName, buildNumber, imagePath, module string, expectedArtifacts, expectedDependencies int, t *testing.T) {
	validateContainerImage(t, imagePath, 7)
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
	if err != nil {
		assert.NoError(t, err)
		return
	}
	if !found {
		assert.True(t, found, "build info was expected to be found")
		return
	}
	buildInfo := publishedBuildInfo.BuildInfo
	validateBuildInfo(buildInfo, t, expectedDependencies, expectedArtifacts, module, entities.Docker)
}

func validateContainerImage(t *testing.T, imagePath string, expectedItemsInArtifactory int) {
	specFile := spec.NewBuilder().Pattern(imagePath + "*").BuildSpec()
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(specFile)
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	length, err := reader.Length()
	assert.NoError(t, err)
	assert.Equal(t, expectedItemsInArtifactory, length, "Container build info was not pushed correctly")
	readerCloseAndAssert(t, reader)
}

func TestKanikoBuildCollect(t *testing.T) {
	if !*tests.TestDocker {
		t.Skip("Skipping test. To run it, add the '-test.docker=true' option.")
	}
	for _, repo := range []string{tests.DockerVirtualRepo, tests.DockerLocalRepo} {
		imageName := "hello-world-or"
		imageTag := imageName + ":latest"
		buildNumber := "1"
		registryDestination := path.Join(tests.RtContainerHostName, repo, imageTag)
		kanikoOutput := runKaniko(t, registryDestination)

		// Run 'build-docker-create' & publish the results to Artifactory.
		runRt(t, "build-docker-create", repo, "--image-file="+kanikoOutput, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber)
		runRt(t, "build-publish", tests.DockerBuildName, buildNumber)

		// Validate.
		publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, tests.DockerBuildName, buildNumber)
		if err != nil {
			assert.NoError(t, err)
			return
		}
		if !found {
			assert.True(t, found, "build info was expected to be found")
			return
		}
		buildInfo := publishedBuildInfo.BuildInfo
		validateBuildInfo(buildInfo, t, 0, 3, imageTag, entities.Docker)

		// Cleanup.
		inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, imageName, tests.DockerBuildName, repo)
		assert.NoError(t, fileutils.RemoveTempDir(tests.Out))
	}
}

// Kaniko is an image builder. We use it to build an image and push it to Artifactory.
// Returns the built image metadata file
func runKaniko(t *testing.T, imageToPush string) string {
	testDir := tests.GetTestResourcesPath()
	dockerFile := "TestKanikoBuildCollect"
	KanikoOutputFile := "image-file"
	if *tests.JfrogAccessToken != "" {
		origUsername, origPassword := tests.SetBasicAuthFromAccessToken()
		defer func() {
			*tests.JfrogUser = origUsername
			*tests.JfrogPassword = origPassword
		}()
	}

	// Create Artifactory credentials file.
	credentialsFile, err := tests.ReplaceTemplateVariables(filepath.Join(testDir, tests.KanikoConfig), tests.Out)
	assert.NoError(t, err)
	credentialsFile, err = filepath.Abs(credentialsFile)
	assert.NoError(t, err)
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, biutils.CopyFile(workspace, filepath.Join(testDir, "docker", dockerFile)))

	// Run Kaniko to build the test image and push it to Artifactory.
	_, err = tests.NewContainerRequest().
		Image(kanikoImage).
		Networks(rtNetwork).
		Mount(
			mount.Mount{Type: mount.TypeBind, Source: workspace, Target: "/workspace", ReadOnly: false},
			mount.Mount{Type: mount.TypeBind, Source: credentialsFile, Target: "/kaniko/.docker/config.json", ReadOnly: true}).
		Cmd("--dockerfile=/workspace/"+dockerFile, "--destination="+imageToPush, "--insecure", "--skip-tls-verify", "--image-name-with-digest-file="+KanikoOutputFile).
		WaitFor(wait.ForExit().WithExitTimeout(300000*time.Millisecond)).
		Build(context.Background(), true)
	assert.NoError(t, err)

	// Return a file contains the image metadata which was built by Kaniko.
	return filepath.Join(workspace, KanikoOutputFile)
}

func TestNativeDockerPushPull(t *testing.T) {
	cleanup := initNativeDockerWithArtTest(t)
	defer cleanup()
	pushBuildNumber := "2"
	image, err := inttestutils.BuildTestImage(tests.DockerImageName+":"+pushBuildNumber, "", tests.DockerLocalRepo, container.DockerClient)
	assert.NoError(t, err)
	defer tests2.DeleteTestImage(t, image, container.DockerClient)
	defer inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, tests.DockerImageName, tests.DockerBuildName, tests.DockerLocalRepo)
	runCmdWithRetries(t, jfCliTask("docker", "-D", "push", image, "--detailed-summary=true"))
	imagePath := path.Join(tests.DockerLocalRepo, tests.DockerImageName, pushBuildNumber) + "/"
	validateContainerImage(t, imagePath, 7)
	tests2.DeleteTestImage(t, image, container.DockerClient)
	runCmdWithRetries(t, jfCliTask("docker", "-D", "pull", image, "--detailed-summary=true"))
}

func TestNativeDockerFlagParsing(t *testing.T) {
	cleanup := initNativeDockerWithArtTest(t)
	defer cleanup()

	dockerTestCases := []struct {
		name        string
		args        []string
		expectedErr error
	}{
		{"docker", []string{"docker"}, nil},
		{"docker version", []string{"docker", "version"}, nil},
		{"docker scan", []string{"docker", "scan", "--min-severity=low"}, errors.New("a docker image name must be provided")},
		{"cli flags after args", []string{"docker", "version", "--build-name=d", "--build-number=1", "--module=1"}, nil},
		{"cli flags before args", []string{"docker", "--build-name=d", "--build-number=1", "--module=1", "version"}, nil},
	}
	for _, testCase := range dockerTestCases {
		t.Run(testCase.name, func(t *testing.T) {
			if testCase.expectedErr != nil {
				err := runJfrogCliWithoutAssertion(testCase.args...)
				assert.EqualError(t, err, testCase.expectedErr.Error())
				return
			}
			runCmdWithRetries(t, jfCliTask(testCase.args...))
		})
	}
}

func TestDockerLoginWithServer(t *testing.T) {
	cleanup := initNativeDockerWithArtTest(t)
	defer cleanup()

	var credentials string
	if *tests.JfrogAccessToken != "" {
		credentials = "--access-token=" + *tests.JfrogAccessToken
	} else {
		credentials = "--user=" + *tests.JfrogUser + " --password=" + *tests.JfrogPassword
	}
	err := coreTests.NewJfrogCli(execMain, "jfrog config", credentials).Exec("add", "artDocker", "--interactive=false", "--url="+"http://localhost:8082", "--enc-password="+strconv.FormatBool(true), "--overwrite")
	assert.NoError(t, err)

	imageName := path.Join(*tests.ContainerRegistry, tests.DockerRemoteRepo, "alpine:latest")

	// Ensure we're logged out first
	cmd := exec.Command("docker", "logout", *tests.ContainerRegistry)
	_, err = cmd.CombinedOutput()
	assert.NoError(t, err)

	// since we're logged out, pulling should fail
	cmd = exec.Command("docker", "pull", imageName)
	output, err := cmd.CombinedOutput()
	assert.Error(t, err)
	assert.Contains(t, string(output), "Authentication is required")

	// Login (perform jf docker login)
	err = runJfrogCliWithoutAssertion("docker", "login", "--server-id=artDocker")
	assert.NoError(t, err)

	// pull should work now
	cmd = exec.Command("docker", "pull", imageName)
	output, err = cmd.CombinedOutput()
	assert.NoError(t, err)
	assert.Contains(t, string(output), "Downloaded newer image")
}

func TestDockerLoginWithRegistry(t *testing.T) {
	cleanup := initNativeDockerWithArtTest(t)
	defer cleanup()

	imageName := path.Join(*tests.ContainerRegistry, tests.DockerRemoteRepo, "busybox:latest")

	// Ensure we're logged out first
	cmd := exec.Command("docker", "logout", *tests.ContainerRegistry)
	_, err := cmd.CombinedOutput()
	assert.NoError(t, err)

	// since we're logged out, pulling should fail
	cmd = exec.Command("docker", "pull", imageName)
	output, err := cmd.CombinedOutput()
	assert.Error(t, err)
	assert.Contains(t, string(output), "Authentication is required")

	// Login (perform jf docker login)
	err = runJfrogCliWithoutAssertion("docker", "login", *tests.ContainerRegistry)
	assert.NoError(t, err)

	// pull should work now
	cmd = exec.Command("docker", "pull", imageName)
	output, err = cmd.CombinedOutput()
	assert.NoError(t, err)
	assert.Contains(t, string(output), "Downloaded newer image")
}

func TestDockerLoginWithRegistryUserAndPass(t *testing.T) {
	cleanup := initNativeDockerWithArtTest(t)
	defer cleanup()

	imageName := path.Join(*tests.ContainerRegistry, tests.DockerRemoteRepo, "hello-world:linux")

	// Ensure we're logged out first
	cmd := exec.Command("docker", "logout", *tests.ContainerRegistry)
	_, err := cmd.CombinedOutput()
	assert.NoError(t, err)

	// since we're logged out, pulling should fail
	cmd = exec.Command("docker", "pull", imageName)
	output, err := cmd.CombinedOutput()
	assert.Error(t, err)
	assert.Contains(t, string(output), "Authentication is required")

	// Login (perform jf docker login)
	password := *tests.JfrogPassword
	if *tests.JfrogAccessToken != "" {
		password = *tests.JfrogAccessToken
	}
	err = runJfrogCliWithoutAssertion("docker", "login", *tests.ContainerRegistry, "--username="+*tests.JfrogUser, "--password="+password)
	assert.NoError(t, err)

	// pull should work now
	cmd = exec.Command("docker", "pull", imageName)
	output, err = cmd.CombinedOutput()
	assert.NoError(t, err)
	assert.Contains(t, string(output), "Downloaded newer image")
}

func jfrogRtCliTask(args ...string) func() error {
	return func() error {
		return artifactoryCli.Exec(args...)
	}
}

func jfCliTask(args ...string) func() error {
	return func() error {
		return coreTests.NewJfrogCli(execMain, "jf", "").WithoutCredentials().Exec(args...)
	}
}

func runCmdWithRetries(t *testing.T, task func() error) {
	maxRetries := 10
	executor := &clientUtils.RetryExecutor{
		MaxRetries:               maxRetries,
		RetriesIntervalMilliSecs: 10000,
		LogMsgPrefix:             "[retries on]",
		ErrorMessage:             fmt.Sprintf("failed to run the command with %d retries.\n", maxRetries),
		ExecutionHandler: func() (bool, error) {
			err := task()
			return err != nil, err
		},
	}
	assert.NoError(t, executor.Execute())
}

func validateDockerBuildInfo(t *testing.T, buildName, buildNumber string, expectedArtifacts bool) {
	// Get and validate build-info
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
	assert.NoError(t, err)
	assert.True(t, found, "build info was expected to be found")

	buildInfo := publishedBuildInfo.BuildInfo
	assert.NotNil(t, buildInfo)
	assert.NotEmpty(t, buildInfo.Modules)

	// Check module
	module := buildInfo.Modules[0]
	assert.Equal(t, entities.Docker, module.Type)

	// Check dependencies count
	assert.NotEmpty(t, module.Dependencies)
	assert.True(t, len(module.Dependencies) > 0, "expected dependencies but found none")

	// Check artifacts count
	if expectedArtifacts {
		assert.NotEmpty(t, module.Artifacts)
		assert.True(t, len(module.Artifacts) > 0, "expected artifacts but found none")
	} else {
		assert.Empty(t, module.Artifacts, "expected no artifacts but found some")
	}

	// Check properties
	assert.NotNil(t, module.Properties)
	assert.Contains(t, module.Properties, "docker.image.tag")
	assert.Contains(t, module.Properties, "docker.build.command")

	// Check config digest - should be present when image was pushed
	if expectedArtifacts {
		assert.Contains(t, module.Properties, "docker.image.id")
		props, ok := module.Properties.(map[string]string)
		if ok {
			configDigest := props["docker.image.id"]
			assert.NotEmpty(t, configDigest)
			assert.True(t, strings.HasPrefix(configDigest, "sha256:"))
		}
	}
}

// TestDockerBuildWithBuildInfo tests basic docker build command with build-info collection
func TestDockerBuildWithBuildInfo(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	buildName := tests.DockerBuildName
	buildNumber := "1"
	// Extract hostname from ContainerRegistry (remove protocol if present)
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}
	// Construct image name for Docker (hostname/repo/image:tag format, no protocol)
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-docker-build")
	imageTag := imageName + ":v1"

	log.Info("Building image with oci", imageTag)

	// Create test workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Create simple Dockerfile
	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "nginx:1.28.0")
	dockerfileContent := fmt.Sprintf(`FROM %s
RUN echo "Hello from test"
CMD ["sh"]`, baseImage)

	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code, path built from test workspace

	// clean build before test
	runJfrogCli(t, "rt", "bc", buildName, buildNumber)

	// Run docker build with build-info (--load to make image available locally for cleanup)
	runJfrogCli(t, "docker", "build", "-t", imageTag, "-f", dockerfilePath, "--load", "--build-name="+buildName, "--build-number="+buildNumber, workspace)

	// Publish build info
	runJfrogCli(t, "rt", "build-publish", buildName, buildNumber)

	// Validate build info
	validateDockerBuildInfo(t, buildName, buildNumber, false) // Should have dependencies from base image, no artifacts

	// Cleanup
	tests2.DeleteTestImage(t, imageTag, container.DockerClient)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
}

// TestDockerBuildAndPushWithBuildInfo tests docker build followed by push with full build-info tracking
func TestDockerBuildAndPushWithBuildInfo(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	buildName := tests.DockerBuildName
	buildNumber := "2"
	// Extract hostname from ContainerRegistry (remove protocol if present)
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}
	// Construct image name for Docker (hostname/repo/image:tag format, no protocol)
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-docker-build")
	imageTag := imageName + ":v2"

	log.Info("Building image with oci", imageTag)

	// Create test workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Create simple Dockerfile
	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "nginx:1.28.0")
	dockerfileContent := fmt.Sprintf(`FROM %s
RUN echo "Hello from test"
CMD ["sh"]`, baseImage)

	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code, path built from test workspace

	// Create test file
	testFilePath := filepath.Join(workspace, "test.txt")
	assert.NoError(t, os.WriteFile(testFilePath, []byte("Hello from Docker build test"), 0644)) //#nosec G703 -- test code

	// clean build before test
	runJfrogCli(t, "rt", "bc", buildName, buildNumber)

	// Run docker build with build-info (--push only, image stays in registry not local)
	runJfrogCli(t, "docker", "build", "-t", imageTag, "--push", "-f", dockerfilePath, "--build-name="+buildName, "--build-number="+buildNumber, workspace)

	// Publish build info
	runRt(t, "build-publish", buildName, buildNumber)

	// Validate build info - should have both dependencies and artifacts
	validateDockerBuildInfo(t, buildName, buildNumber, true)

	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
}

// TestDockerBuildMultiStageDockerfile tests multi-stage Dockerfile parsing and dependency collection
func TestDockerBuildMultiStageDockerfile(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	buildName := tests.DockerBuildName
	buildNumber := "1"
	// Extract hostname from ContainerRegistry (remove protocol if present)
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}
	// Construct image name for Docker (hostname/repo/image:tag format, no protocol)
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-docker-build")
	imageTag := imageName + ":v3"

	log.Info("Building image with oci", imageTag)

	// Create test workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Construct base images with hostname (just like imageTag construction)
	golangImage := path.Join(registryHost, tests.OciRemoteRepo, "alpine:latest")
	alpineImage := path.Join(registryHost, tests.OciRemoteRepo, "nginx:latest")

	// Create multi-stage Dockerfile
	dockerfileContent := fmt.Sprintf(`# First stage - builder
FROM %s AS builder
CMD ["hello"]

# second stage - final
FROM %s
CMD ["hello"]`, golangImage, alpineImage)

	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code, path built from test workspace

	// clean build before test
	runJfrogCli(t, "rt", "bc", buildName, buildNumber)

	// Run docker build with build-info (--load to make image available locally for cleanup)
	runJfrogCli(t, "docker", "build", "-t", imageTag, "-f", dockerfilePath, "--load", "--build-name="+buildName, "--build-number="+buildNumber, workspace)

	// Publish build info
	runRt(t, "build-publish", buildName, buildNumber)

	// Validate build info - should have dependencies from golang:1.19-alpine and alpine:3.18
	validateDockerBuildInfo(t, buildName, buildNumber, false)

	// Cleanup
	tests2.DeleteTestImage(t, imageTag, container.DockerClient)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
}

// TestDockerBuildxWithBuildInfo tests buildx build command with build-info collection
func TestDockerBuildxWithBuildInfo(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	buildName := tests.DockerBuildName
	buildNumber := "1"
	// Extract hostname from ContainerRegistry (remove protocol if present)
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}
	// Construct image name for Docker (hostname/repo/image:tag format, no protocol)
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-docker-build")
	imageTag := imageName + ":v4"

	log.Info("Building image with oci", imageTag)
	fullImageName := imageTag

	// Create test workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Construct base image with hostname (just like imageTag construction)
	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "alpine:latest")

	// Create Dockerfile for buildx
	dockerfileContent := fmt.Sprintf(`FROM %s
RUN echo "Built with buildx"
CMD ["echo", "Hello from buildx"]`, baseImage)

	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code, path built from test workspace

	// Check if buildx is available
	cmd := exec.Command("docker", "buildx", "version")
	if err := cmd.Run(); err != nil {
		t.Error("Docker buildx not available, skipping test")
	}

	// clean build before test
	runJfrogCli(t, "rt", "bc", buildName, buildNumber)

	// Run docker buildx build with build-info and push
	runJfrogCli(t, "docker", "buildx", "build", "--platform", "linux/amd64",
		"-t", fullImageName, "-f", dockerfilePath, "--push", "--build-name="+buildName, "--build-number="+buildNumber, workspace)

	// Publish build info
	runJfrogCli(t, "rt", "build-publish", buildName, buildNumber)

	// Validate build info - buildx with --push should have both dependencies and artifacts
	validateDockerBuildInfo(t, buildName, buildNumber, true)

	// Cleanup
	// Extract just the image name (last part) for cleanup
	imageNameOnly := "test-docker-build"
	inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, imageNameOnly, buildName, tests.OciLocalRepo)
}

// TestDockerBuildxSkipLoginFails verifies that --skip-login actually skips login.
// After logging out, buildx --push with --skip-login should fail because no auth is available.
func TestDockerBuildxSkipLoginFails(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	// Prevent urfave/cli from calling os.Exit on command errors
	origOsExiter := urfavecli.OsExiter
	urfavecli.OsExiter = func(code int) {}
	defer func() { urfavecli.OsExiter = origOsExiter }()

	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-skip-login")
	imageTag := imageName + ":v1"

	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "busybox:latest")
	dockerfileContent := fmt.Sprintf(`FROM %s
CMD ["echo", "skip-login test"]`, baseImage)
	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code

	// Logout from registry so push requires fresh login
	logoutCmd := exec.Command("docker", "logout", registryHost)
	assert.NoError(t, logoutCmd.Run())

	// With --skip-login, jf should NOT re-login, so push should fail
	err = runJfrogCliWithoutAssertion("docker", "buildx", "build",
		"--platform", "linux/amd64",
		"-t", imageTag, "-f", dockerfilePath, "--push", "--skip-login", workspace)
	assert.Error(t, err, "Expected failure: --skip-login should prevent auto-login, causing push to fail without auth")

	// Re-login for subsequent tests
	runJfrogCli(t, "docker", "login", registryHost)
}

// TestDockerBuildWithVirtualRepo tests docker build with virtual repository
func TestDockerBuildWithVirtualRepo(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	buildName := tests.DockerBuildName
	buildNumber := "1"
	// Extract hostname from ContainerRegistry (remove protocol if present)
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}
	// Construct image name for Docker (hostname/repo/image:tag format, no protocol)
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-docker-build")
	imageTag := imageName + ":v5"

	log.Info("Building image with oci", imageTag)

	// Create test workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Construct base image with hostname (just like imageTag construction)
	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "alpine:latest")

	// Create Dockerfile that uses image from virtual repo
	dockerfileContent := fmt.Sprintf(`FROM %s
RUN echo "Testing virtual repo"
CMD ["sh"]`, baseImage)

	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code, path built from test workspace

	// clean build before test
	runJfrogCli(t, "rt", "bc", buildName, buildNumber)

	// Run docker build (--push only, image stays in registry not local)
	runJfrogCli(t, "docker", "build", "-t", imageTag, "-f", dockerfilePath, "--push",
		"--build-name="+buildName, "--build-number="+buildNumber, workspace)

	// Publish build info
	runJfrogCli(t, "rt", "build-publish", buildName, buildNumber)

	// Validate build info - virtual repo with push should have both dependencies and artifacts
	validateDockerBuildInfo(t, buildName, buildNumber, true)

	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
}

func TestContainerPullWithSha(t *testing.T) {
	cleanup := initNativeDockerWithArtTest(t)
	defer cleanup()
	var credentials string
	if *tests.JfrogAccessToken != "" {
		credentials = "--access-token=" + *tests.JfrogAccessToken
	} else {
		credentials = "--user=" + *tests.JfrogUser + " --password=" + *tests.JfrogPassword
	}
	err := coreTests.NewJfrogCli(execMain, "jfrog config", credentials).Exec("add", "artDocker", "--interactive=false", "--url="+"http://localhost:8082", "--enc-password="+strconv.FormatBool(true), "--overwrite")
	assert.NoError(t, err)
	runJfrogCli(t, "config", "use", "artDocker")
	imageName, err := inttestutils.BuildTestImage(tests.DockerImageName+":1", "", tests.DockerLocalRepo, container.DockerClient)
	assert.NoError(t, err)
	defer tests2.DeleteTestImage(t, imageName, container.DockerClient)

	// Push container image
	runCmdWithRetries(t, jfrogRtCliTask(container.DockerClient.String()+"-push", imageName, tests.DockerVirtualRepo))
	buildNumber := "1"

	dockerImage := container.DockerImage{
		Image: imageName,
	}
	manifestSha, err := dockerImage.GetManifestDetails()
	assert.NoError(t, err)
	imageTag := strings.ReplaceAll(imageName, ":1", "@"+manifestSha)

	// pull image with SHA
	runJfrogCli(t, "docker", "pull", imageTag, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber)
	runRt(t, "build-publish", tests.DockerBuildName, buildNumber)

	imagePath := path.Join(tests.DockerVirtualRepo, tests.DockerImageName, "1") + "/"
	module := tests.DockerImageName + "@" + manifestSha
	validateContainerBuild(tests.DockerBuildName, buildNumber, imagePath, module, 0, 7, t)

	inttestutils.ContainerTestCleanup(t, serverDetails, artHttpDetails, tests.DockerImageName, tests.DockerBuildName, tests.DockerVirtualRepo)

}

func TestContainerFatManifestPullWithSha(t *testing.T) {
	cleanup := initNativeDockerWithArtTest(t)
	defer cleanup()
	var credentials string
	if *tests.JfrogAccessToken != "" {
		credentials = "--access-token=" + *tests.JfrogAccessToken
	} else {
		credentials = "--user=" + *tests.JfrogUser + " --password=" + *tests.JfrogPassword
	}
	err := coreTests.NewJfrogCli(execMain, "jfrog config", credentials).Exec("add", "artDocker", "--interactive=false", "--url="+"http://localhost:8082", "--enc-password="+strconv.FormatBool(true), "--overwrite")
	assert.NoError(t, err)
	runJfrogCli(t, "config", "use", "artDocker")
	imageName := "traefik"
	buildNumber := "1"
	for _, dockerRepo := range [...]string{tests.DockerRemoteRepo, tests.DockerVirtualRepo} {
		func() {
			// calculate the sha of the image provided above
			dockerImage := container.DockerImage{
				Image: imageName,
			}
			manifestSha, err := dockerImage.GetManifestDetails()
			assert.NoError(t, err)

			imageTag := path.Join(*tests.ContainerRegistry, dockerRepo, imageName+"@"+manifestSha)
			// Pull container image
			defer tests2.DeleteTestImage(t, imageTag, container.DockerClient)
			// pull image with SHA
			runJfrogCli(t, "docker", "pull", imageTag, "--build-name="+tests.DockerBuildName, "--build-number="+buildNumber)
			runRt(t, "build-publish", tests.DockerBuildName, buildNumber)

			// Validate
			publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, tests.DockerBuildName, buildNumber)
			if err != nil {
				assert.NoError(t, err)
				return
			}
			if !found {
				assert.True(t, found, "build info was expected to be found")
				return
			}
			buildInfo := publishedBuildInfo.BuildInfo
			module := imageName + "@" + manifestSha
			validateBuildInfo(buildInfo, t, 6, 0, module, entities.Docker)

			inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.DockerBuildName, artHttpDetails)
		}()
	}

}

// TestDockerBuildPublishWithCIVcsProps tests that CI VCS properties are set on Docker artifacts
// when running build-publish in a CI environment (GitHub Actions).
func TestDockerBuildPublishWithCIVcsProps(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	buildName := "docker-civcs-test"
	buildNumber := "1"

	// Setup GitHub Actions environment (uses real env vars on CI, mock values locally)
	cleanupEnv, actualOrg, actualRepo := tests.SetupGitHubActionsEnv(t)
	defer cleanupEnv()

	// Clean old build
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
	defer inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)

	// Extract hostname from ContainerRegistry
	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}

	// Construct image name
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-civcs-docker")
	imageTag := imageName + ":v1"

	// Create test workspace
	workspace, err := filepath.Abs(tests.Out)
	assert.NoError(t, err)
	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))

	// Create simple Dockerfile
	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "alpine:latest")
	dockerfileContent := fmt.Sprintf(`FROM %s
CMD ["echo", "Hello from CI VCS test"]`, baseImage)

	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	assert.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0644)) //#nosec G703 -- test code, path built from test workspace

	// Clean build before test
	runJfrogCli(t, "rt", "bc", buildName, buildNumber)

	// Run docker build with build-info
	runJfrogCli(t, "docker", "build", "-t", imageTag, "--push", "-f", dockerfilePath, "--build-name="+buildName, "--build-number="+buildNumber, workspace)

	// Publish build info - should set CI VCS props on Docker layers
	runRt(t, "build-publish", buildName, buildNumber)

	// Validate build info was published with artifacts
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
	if err != nil {
		assert.NoError(t, err)
		return
	}
	if !found {
		assert.True(t, found, "build info was expected to be found")
		return
	}

	// Create service manager for getting artifact properties
	serviceManager, err := utils.CreateServiceManager(serverDetails, 3, 1000, false)
	assert.NoError(t, err)

	// Verify VCS properties on each artifact from build info
	artifactCount := 0
	for _, module := range publishedBuildInfo.BuildInfo.Modules {
		for _, artifact := range module.Artifacts {
			// Docker artifacts may have empty OriginalDeploymentRepo - use the known repo
			repo := artifact.OriginalDeploymentRepo
			if repo == "" {
				repo = tests.OciLocalRepo
			}
			fullPath := repo + "/" + artifact.Path

			props, err := serviceManager.GetItemProps(fullPath)
			assert.NoError(t, err, "Failed to get properties for artifact: %s", fullPath)
			assert.NotNil(t, props, "Properties are nil for artifact: %s", fullPath)

			// Validate VCS properties
			assert.Contains(t, props.Properties, "vcs.provider", "Missing vcs.provider on %s", artifact.Name)
			assert.Contains(t, props.Properties["vcs.provider"], "github", "Wrong vcs.provider on %s", artifact.Name)

			assert.Contains(t, props.Properties, "vcs.org", "Missing vcs.org on %s", artifact.Name)
			assert.Contains(t, props.Properties["vcs.org"], actualOrg, "Wrong vcs.org on %s", artifact.Name)

			assert.Contains(t, props.Properties, "vcs.repo", "Missing vcs.repo on %s", artifact.Name)
			assert.Contains(t, props.Properties["vcs.repo"], actualRepo, "Wrong vcs.repo on %s", artifact.Name)

			artifactCount++
		}
	}
	assert.Greater(t, artifactCount, 0, "No artifacts in build info")
}

// TestDockerPushWithLocalGitVcsProps verifies local git VCS props on Docker artifacts
// when running build-publish with VCS collection enabled and no CI env.
func TestDockerPushWithLocalGitVcsProps(t *testing.T) {
	cleanup := initDockerBuildTest(t)
	defer cleanup()

	buildName := "docker-local-git-test"
	buildNumber := "1"

	cleanupEnv := tests.SetupLocalGitVcsEnv(t)
	defer cleanupEnv()

	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
	defer inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)

	registryHost := *tests.ContainerRegistry
	if parsedURL, err := url.Parse(registryHost); err == nil && parsedURL.Host != "" {
		registryHost = parsedURL.Host
	}
	imageName := path.Join(registryHost, tests.OciLocalRepo, "test-local-git-docker")
	imageTag := imageName + ":v1"

	workspace, err := filepath.Abs(tests.Out)
	require.NoError(t, err)
	require.NoError(t, fileutils.CreateDirIfNotExist(workspace))
	tests.CopyGitFixtureIntoProject(t, workspace)

	baseImage := path.Join(registryHost, tests.OciRemoteRepo, "alpine:latest")
	dockerfileContent := fmt.Sprintf("FROM %s\nCMD [\"echo\", \"local git vcs test\"]", baseImage)
	dockerfilePath := filepath.Join(workspace, "Dockerfile")
	require.NoError(t, os.WriteFile(dockerfilePath, []byte(dockerfileContent), 0o644)) //#nosec G703 -- test code, path built from test workspace

	runJfrogCli(t, "rt", "bc", buildName, buildNumber)
	runJfrogCli(t, "docker", "build", "-t", imageTag, "--push", "-f", dockerfilePath,
		"--build-name="+buildName, "--build-number="+buildNumber, workspace)
	runRt(t, "build-publish", buildName, buildNumber, "--dot-git-path", workspace)

	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
	require.NoError(t, err)
	require.True(t, found)

	serviceManager, err := utils.CreateServiceManager(serverDetails, 3, 1000, false)
	require.NoError(t, err)

	count := tests.ValidateLocalGitVcsPropsOnBuildInfoArtifacts(t, serviceManager, publishedBuildInfo, tests.OciLocalRepo,
		tests.VcsFixtureMainURL, tests.VcsFixtureMainRevision, tests.VcsFixtureMainBranch)
	assert.Greater(t, count, 0)
}

// TestSetupDockerCommand verifies `jf setup docker --url ...` end-to-end.
//
// Guards RTECO-1352: configureContainer (in jfrog-cli-artifactory) used to read
// ServerDetails.GetUrl(), which createServerDetailsFromFlags clears for the Rt
// command domain after copying it into ArtifactoryUrl. On the --url invocation
// path that left the registry host empty and routed `docker login ""` to Docker
// Hub, producing a misleading 401. The corresponding fix in jfrog-cli-artifactory
// derives the host from GetArtifactoryUrl() (with GetUrl() fallback for the
// --server-id path) and asserts a non-empty host.
//
// This e2e test exercises the *exact* failure path — `--url` + `--access-token`
// flags with no saved config — and verifies that the docker config file ends up
// with an auth entry keyed by the Artifactory registry hostname.
func TestSetupDockerCommand(t *testing.T) {
	if !*tests.TestDocker {
		t.Skip("Skipping setup docker test. To run it, add the '-test.docker=true' option.")
	}

	// Isolate the docker config to a temp dir so the test never touches the
	// developer's ~/.docker/config.json. The docker CLI honors DOCKER_CONFIG
	// as the config-file directory.
	dockerConfigDir := t.TempDir()
	t.Setenv("DOCKER_CONFIG", dockerConfigDir)

	// Build credentials from the test globals. The --url path is what the bug
	// hit, so pass it explicitly along with --access-token (or --user/--password)
	// rather than relying on a saved server config.
	artifactoryUrl := *tests.JfrogUrl + tests.ArtifactoryEndpoint
	user := *tests.JfrogUser
	credFlag := ""
	switch {
	case *tests.JfrogAccessToken != "":
		credFlag = "--access-token=" + *tests.JfrogAccessToken
		if user == "" {
			user = auth.ExtractUsernameFromAccessToken(*tests.JfrogAccessToken)
		}
	case *tests.JfrogPassword != "":
		credFlag = "--password=" + *tests.JfrogPassword
	default:
		t.Skip("Skipping setup docker test: no JFrog credentials available.")
	}

	jfrogCli := coreTests.NewJfrogCli(execMain, "jfrog", "")
	require.NoError(t, jfrogCli.Exec(
		"setup", "docker",
		"--url="+artifactoryUrl,
		"--user="+user,
		credFlag,
		"--repo="+tests.DockerVirtualRepo,
	))

	// Derive the expected registry host the same way the fix does: take the
	// host component of the Artifactory URL.
	parsedUrl, err := url.Parse(artifactoryUrl)
	require.NoError(t, err)
	expectedRegistryHost := parsedUrl.Host
	require.NotEmpty(t, expectedRegistryHost, "Artifactory URL must have a host")

	// Verify the docker config file was updated with an auth entry for the
	// derived registry host. Before the fix the entry would have been keyed by
	// an empty string (and the underlying `docker login` would have failed).
	dockerConfigPath := filepath.Join(dockerConfigDir, "config.json")
	contentBytes, err := os.ReadFile(dockerConfigPath)
	require.NoError(t, err, "docker config file should be created by setup docker")
	assert.Contains(t, string(contentBytes), expectedRegistryHost,
		"docker config should contain the Artifactory registry host derived from --url")
}