forked from CrazyCoder/Wox.Plugin.Runner
-
Notifications
You must be signed in to change notification settings - Fork 6
File explorer support #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6a67fd1
File explorer support
stefnotch 3cc47fe
Update to .Net 5 build
jjw24 95f0e1c
Update to .Net 5 publish
jjw24 360aa1e
Remove useless lines from .csproj
stefnotch c6c05a6
Fix null warnings
stefnotch 6bd718d
Merge remote-tracking branch 'stefnotch/feat-file-explorer' into feat…
stefnotch 1fcc0e7
Tweak null checks
stefnotch 858002c
Slightly tweak the explorer paths getting
stefnotch 3fd1fc3
Add a comment
stefnotch c48ed99
Adjust UI For button to display
taooceros a0f66e8
Update Version
taooceros ccbbe45
update readme
jjw24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ namespace Wox.Plugin.Runner.Settings | |
| { | ||
| public class RunnerSettingsViewModel | ||
| { | ||
| private readonly PluginInitContext context; | ||
| private readonly PluginInitContext? context; | ||
|
|
||
| public RunnerSettingsViewModel() { } | ||
|
|
||
|
|
@@ -21,9 +21,9 @@ public void LoadCommands() | |
| RunnerConfiguration.Commands.Select( c => new CommandViewModel( c ) ) ); | ||
| } | ||
|
|
||
| public ObservableCollection<CommandViewModel> Commands { get; set; } | ||
| public ObservableCollection<CommandViewModel>? Commands { get; set; } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe refactor a bit to make this not nullable. The viewmodel is not intended to have null Commands. |
||
|
|
||
| public CommandViewModel SelectedCommand { get; set; } | ||
| public CommandViewModel? SelectedCommand { get; set; } | ||
|
|
||
| public bool CommandIsSelected | ||
| { | ||
|
|
@@ -36,22 +36,22 @@ public bool CommandIsSelected | |
| public void Add() | ||
| { | ||
| var cmd = new CommandViewModel(new Command()); | ||
| Commands.Add(cmd); | ||
| Commands!.Add(cmd); | ||
| SelectedCommand = cmd; | ||
| } | ||
|
|
||
| public void SaveChanges() | ||
| { | ||
| RunnerConfiguration.Commands = Commands.Select(c => c.GetCommand()); | ||
| RunnerConfiguration.Commands = Commands!.Select(c => c.GetCommand()); | ||
|
|
||
| context.API.ShowMsg("Your changes have been saved!"); | ||
| context!.API.ShowMsg("Your changes have been saved!"); | ||
| } | ||
|
|
||
| public void Delete(CommandViewModel cmdToDelete) | ||
| { | ||
| if (cmdToDelete != null) | ||
| { | ||
| Commands.Remove(cmdToDelete); | ||
| Commands!.Remove(cmdToDelete); | ||
| SelectedCommand = null; | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.