feat: query sensors only if they exist, batch sensor data requests#650
Merged
aleclevy merged 5 commits intoMar 5, 2026
Merged
Conversation
Contributor
|
@aabhinavvvvvvv This pr caused an api issue to arise with Marshmallow 'cellIDs' marshmallow.exceptions.ValidationError: {'cellIds': ['Unknown field.']} |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #642
The dashboard was rendering all 14 chart types unconditionally for every selected cell, firing up to 14 × N API requests on each cell selection — most returning empty data. This PR adds a sensor existence check and batch data fetching to eliminate wasted requests.
GET /api/cell-sensors/endpoint returning which sensor names exist per cellGET /api/sensor/to acceptcellIds(comma-separated) for batch queries, returning data grouped by cell in a single responseUnifiedChartnow makes 1 batch request per measurement type instead of 1 request per cell × per measurement