Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Series information to main Release information #151

Open
VinylVault opened this issue Aug 26, 2024 · 2 comments
Open

Promote Series information to main Release information #151

VinylVault opened this issue Aug 26, 2024 · 2 comments
Labels
feature request New feature or request

Comments

@VinylVault
Copy link
Contributor

VinylVault commented Aug 26, 2024

I know that series information is available via fetch, but it would be useful if this was available (or null) at the top level of a release

Original discussion: #150

@JOJ0 JOJ0 added the feature request New feature or request label Sep 4, 2024
@JOJ0
Copy link
Contributor

JOJ0 commented Sep 4, 2024

This should be easy enough to implement. Similar to this one: https://github.com/joalla/discogs_client/pull/119/files but I'm not sure if Series could be ListField or rather be an ObjectField? What does the API for series return? Is it always a list of JSON objects? Or could it also be one JSON object only? Some raw API output would help to find out @VinylVault

ListField example: https://github.com/joalla/discogs_client/blob/master/discogs_client/models.py#L525

ObjectField example https://github.com/joalla/discogs_client/blob/master/discogs_client/models.py#L527

You want to draft a PR @VinylVault ? I'm happy to review and help then.

@VinylVault
Copy link
Contributor Author

There is only ever on Series, that I've come across, but that isn't necessarily the case for every release ... probably best to treat is like an artist or record label (seeing as they are stored as labels and URL'd as labels [don't as me why])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Development

No branches or pull requests

2 participants