Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discogs_client.tests.test_utils.UtilsTestCase.test_sort fails on Python 3.13 #156

Closed
wRAR opened this issue Oct 6, 2024 · 11 comments
Closed

Comments

@wRAR
Copy link

wRAR commented Oct 6, 2024

FAIL: test_sort (discogs_client.tests.test_utils.UtilsTestCase.test_sort)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "discogs_client/discogs_client/tests/test_utils.py", line 76, in test_sort
    self.assertEqual(utils.Sort.By.ARTIST, 'artist')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: <By.ARTIST: 'artist'> != 'artist'

Found in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082206 and I can confirm it locally.

@JOJ0
Copy link
Contributor

JOJ0 commented Oct 26, 2024

@wRAR this is a very old version of python3-discogs-client and I'm wondering how the official way to remove a package from the Debian archives would be? We don't want to maintain the Debian package anymore. Can you help us with that matter?

@wRAR
Copy link
Author

wRAR commented Oct 26, 2024

@JOJ0 the official way to remove a package from Debian unstable/testing is making sure there are no reverse dependencies (there are currently two direct ones) and then filing an RM bug.

@JOJ0
Copy link
Contributor

JOJ0 commented Nov 7, 2024

@wRAR thanks a lot, sorry for late reply, I should finally get to removing it. One dependency is github.com/joj0/discodos.git, not sure about the second yet.

@wRAR
Copy link
Author

wRAR commented Nov 7, 2024

beets uses python3-discogs-client for build-time tests and autopkgtests.

@JOJ0
Copy link
Contributor

JOJ0 commented Nov 12, 2024

@wRAR Hi sgain I'm so sorry that I'm so bad at this and slow to respond/act.

I justrealized that python-discogs-client is somewhat maintained in Debian. Who is the maintainer? I see v2.5, which is notterribly old but most importantly I think we recently fixedsom Pytjon 12 related things which might address the issue: https://github.com/joalla/discogs_client/pull/141/files

What I could do to help js push out a pypi release by the end of this week

@wRAR
Copy link
Author

wRAR commented Nov 12, 2024

I justrealized that python-discogs-client is somewhat maintained in Debian.

I can't say so. If you no longer want to be listed as its maintainer it must be formally orphaned as there are no other human maintainers listed.

I see v2.5

It was uploaded 2 years ago as a team upload.

@JOJ0
Copy link
Contributor

JOJ0 commented Nov 14, 2024

Ok, hi again @wRAR thanks again for the patience. I now did the following:

After thinking this through again I believe that the package is essential to stay in Debian since https://packages.debian.org/source/trixie/beets depends on it and I can imagine that having beets available out-of-the box on Debian is worth it.

Thanks for pointing me in the right direction @wRAR, is there anything else I can do?

@wRAR
Copy link
Author

wRAR commented Nov 14, 2024

is there anything else I can do?

No, though I suggest considering doing the same for other your packages you don't want to maintain. Thanks.

@JOJ0
Copy link
Contributor

JOJ0 commented Nov 15, 2024

is there anything else I can do?

No, though I suggest considering doing the same for other your packages you don't want to maintain. Thanks.

Yes. Thanks. A little off-topic in this repo but I don't care and I think it's not a big deal for my fellow repo owners if I continue to talk about "other" Debian packages within this issue :-)

I just filed removal requests for the remaining two packages I'm listed as a maintainer. I was not 100% sure if filing against releases.debian.org was correct (since they are in testing already). My goal is to remove them from Debian entirely.

Would I now have to file another bug against ftp.debian.org to remove them from unstable/sid? Or is it sufficient like that?

@wRAR
Copy link
Author

wRAR commented Nov 15, 2024

The correct way to remove a package from Debian is to file a removal from sid against ftp.debian.org. https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#removing-packages

@JOJ0
Copy link
Contributor

JOJ0 commented Feb 19, 2025

I think this is sorted by now. I'll close this one and thanks again for all the help @wRAR

@JOJ0 JOJ0 closed this as completed Feb 19, 2025
@github-project-automation github-project-automation bot moved this from Todo to Closed in python3-discogs-client Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants