Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale branches #667

Closed
aadcg opened this issue Feb 4, 2025 · 5 comments
Closed

Stale branches #667

aadcg opened this issue Feb 4, 2025 · 5 comments

Comments

@aadcg
Copy link
Collaborator

aadcg commented Feb 4, 2025

@joaotavora I noticed that there are countless stale branches on this repository. Is there a good reason for that? I'd like to delete all of them.

@joaotavora
Copy link
Owner

Is there good reason for wanting to delete them? :-)

Or is cleanup for cleanup sake the reason in itself, to organize yourself perhaps. But OK, can you list the branches you'd like to delete here?

@aadcg
Copy link
Collaborator Author

aadcg commented Feb 4, 2025

I should have framed it in the context of #664 (comment).

When looking for the commit, I've noticed many seemingly "abandoned" branches (some of them are over 10 years). See https://github.com/joaotavora/sly/branches/stale.

For example, see branch master...fix/568-dont-prevent-gc-from-inspector-references. Its only commit landed on master as c2187da. This seems to indicate that you forgot to delete it.

@joaotavora
Copy link
Owner

joaotavora commented Feb 4, 2025

Well, SLY is a relatively old project, I started it circa 2013. I don't know, I don't mind the branches and they keep a sense of history. Recently, I used grep to find a really old branch in another project that was still useful. I don't mind renaming the branches to give them some prefix (perhaps for those that don't have one). But I think deleting them altogether and dangle the commits is not a good idea. I know some companies obsessed with deleting old branches, but I never understood the rationale for it, I think it's just sysadmins misunderstanding Git.

@joaotavora
Copy link
Owner

For example, see branch master...fix/568-dont-prevent-gc-from-inspector-references. Its only commit landed on master as c2187da. This seems to indicate that you forgot to delete it.

I didn't forget. I simply never delete, unless I know it will bring some kind of confusion. It doesn't bother me to have it there. I never git fetch without remote and branch these days, and god forbid I use some of those "convenience" GUI tools :-)

@aadcg
Copy link
Collaborator Author

aadcg commented Feb 4, 2025

Interesting take. I disagree but respect your view :)

@aadcg aadcg closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants