Skip to content

Use spotless to enforce style and apply #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use spotless to enforce style and apply #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4bd1dd
feat: add spotless
juherr Sep 4, 2025
d0366ee
chore: apply spotless
juherr Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: analyze and review code
on: [ push, pull_request ]

jobs:
style-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
with:
fetch-depth: 0

- name: Setup Java
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: 8
cache: maven

- name: Check code style
run: ./mvnw spotless:check
144 changes: 72 additions & 72 deletions jsonschema2pojo-ant/src/main/java/org/jsonschema2pojo/ant/AntRuleLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,77 +21,77 @@

public class AntRuleLogger extends AbstractRuleLogger {

private static final String LEVEL_PREFIX = "[";
private static final String LEVEL_SUFFIX = "] ";
private static final String DEBUG_LEVEL_PREFIX = LEVEL_PREFIX + "DEBUG" + LEVEL_SUFFIX;
private static final String ERROR_LEVEL_PREFIX = LEVEL_PREFIX + "ERROR" + LEVEL_SUFFIX;
private static final String INFO_LEVEL_PREFIX = LEVEL_PREFIX + "INFO" + LEVEL_SUFFIX;
private static final String TRACE_LEVEL_PREFIX = LEVEL_PREFIX + "TRACE" + LEVEL_SUFFIX;
private static final String WARN_LEVEL_PREFIX = LEVEL_PREFIX + "WARN" + LEVEL_SUFFIX;

private final Jsonschema2PojoTask task;

public AntRuleLogger(Jsonschema2PojoTask jsonschema2PojoTask) {
this.task = jsonschema2PojoTask;
}

@Override
public boolean isDebugEnabled() {
return true;
}

@Override
public boolean isErrorEnabled() {
return true;
}

@Override
public boolean isInfoEnabled() {
return true;
}

@Override
public boolean isTraceEnabled() {
return true;
}

@Override
public boolean isWarnEnabled() {
return true;
}

protected void doDebug(String msg) {
log(msg, null, Project.MSG_DEBUG, DEBUG_LEVEL_PREFIX);
}

protected void doError(String msg, Throwable e) {
log(msg, e, Project.MSG_ERR, ERROR_LEVEL_PREFIX);
}

protected void doInfo(String msg) {
log(msg, null, Project.MSG_INFO, INFO_LEVEL_PREFIX);
}

protected void doTrace(String msg) {
log(msg, null, Project.MSG_VERBOSE, TRACE_LEVEL_PREFIX);
}

protected void doWarn(String msg, Throwable e) {
log(msg, null, Project.MSG_WARN, WARN_LEVEL_PREFIX);
}

private void log(String msg, Throwable e, int level, String levelPrefix) {
if (task != null && task.getProject() != null) {
if(e != null) {
task.getProject().log(msg, e, level);
} else {
task.getProject().log(msg, level);
}
} else {
System.err.println(levelPrefix + msg);
if(e != null) {
e.printStackTrace(System.err);
}
private static final String LEVEL_PREFIX = "[";
private static final String LEVEL_SUFFIX = "] ";
private static final String DEBUG_LEVEL_PREFIX = LEVEL_PREFIX + "DEBUG" + LEVEL_SUFFIX;
private static final String ERROR_LEVEL_PREFIX = LEVEL_PREFIX + "ERROR" + LEVEL_SUFFIX;
private static final String INFO_LEVEL_PREFIX = LEVEL_PREFIX + "INFO" + LEVEL_SUFFIX;
private static final String TRACE_LEVEL_PREFIX = LEVEL_PREFIX + "TRACE" + LEVEL_SUFFIX;
private static final String WARN_LEVEL_PREFIX = LEVEL_PREFIX + "WARN" + LEVEL_SUFFIX;

private final Jsonschema2PojoTask task;

public AntRuleLogger(Jsonschema2PojoTask jsonschema2PojoTask) {
this.task = jsonschema2PojoTask;
}

@Override
public boolean isDebugEnabled() {
return true;
}

@Override
public boolean isErrorEnabled() {
return true;
}

@Override
public boolean isInfoEnabled() {
return true;
}

@Override
public boolean isTraceEnabled() {
return true;
}

@Override
public boolean isWarnEnabled() {
return true;
}

protected void doDebug(String msg) {
log(msg, null, Project.MSG_DEBUG, DEBUG_LEVEL_PREFIX);
}

protected void doError(String msg, Throwable e) {
log(msg, e, Project.MSG_ERR, ERROR_LEVEL_PREFIX);
}

protected void doInfo(String msg) {
log(msg, null, Project.MSG_INFO, INFO_LEVEL_PREFIX);
}

protected void doTrace(String msg) {
log(msg, null, Project.MSG_VERBOSE, TRACE_LEVEL_PREFIX);
}

protected void doWarn(String msg, Throwable e) {
log(msg, null, Project.MSG_WARN, WARN_LEVEL_PREFIX);
}

private void log(String msg, Throwable e, int level, String levelPrefix) {
if (task != null && task.getProject() != null) {
if (e != null) {
task.getProject().log(msg, e, level);
} else {
task.getProject().log(msg, level);
}
} else {
System.err.println(levelPrefix + msg);
if (e != null) {
e.printStackTrace(System.err);
}
}
}
}
}
Loading
Loading