Skip to content

Why isn't BasicBlock autofilled for each type? #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iwinux opened this issue Feb 23, 2024 · 1 comment · May be fixed by #185
Open

Why isn't BasicBlock autofilled for each type? #173

iwinux opened this issue Feb 23, 2024 · 1 comment · May be fixed by #185

Comments

@iwinux
Copy link

iwinux commented Feb 23, 2024

Currently we need to explicitly specify BasicBlock, set the Type field with consts like BlockTypeTableOfContents. It's very tedious and error-prone (no validation if I set the wrong type for TableOfContentsBlock.BasicBlock.Type).
@amberpixels amberpixels linked a pull request Dec 20, 2024 that will close this issue
Open
@amberpixels
Copy link

amberpixels commented Dec 20, 2024 •
edited
Loading

I had such helper constructors in my local fork, so it's been requested - I'm making a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Block Constructors amberpixels/notionapi
2 participants
@iwinux @amberpixels