pkp#8845 Improved visibility of variables

Author: jonasraoni

classes/config/ConfigParser.php

@@ -138,6 +138,7 @@ public function updateConfig($file, $params)
         $lines = file($file);
 
         // Parse each line of the configuration file
+        $currentSection = null;
         for ($i = 0, $count = count($lines); $i < $count; $i++) {
             $line = $lines[$i];
 

classes/filter/Filter.php

@@ -414,6 +414,7 @@ public function supportsAsInput(&$input)
     public function isCompatibleWithRuntimeEnvironment()
     {
         if ($this->_runtimeEnvironment === false) {
+            $phpVersionMin = $phpVersionMax = $phpExtensions = $externalPrograms = null;
             // The runtime environment has never been
             // queried before.
             $runtimeSettings = $this->supportedRuntimeEnvironmentSettings();

classes/search/SubmissionSearch.php

@@ -264,6 +264,7 @@ public function retrieveResults($request, $context, $keywords, &$error, $publish
 
         // Check whether a search plug-in jumps in to provide ranked search results.
         $totalResults = null;
+        $results = null;
         $hookResult = Hook::call(
             'SubmissionSearch::retrieveResults',
             [&$context, &$keywords, $publishedFrom, $publishedTo, $orderBy, $orderDir, $exclude, $page, $itemsPerPage, &$totalResults, &$error, &$results]

classes/template/PKPTemplateManager.php

@@ -1759,6 +1759,7 @@ public function smartyUrl($parameters, $smarty)
         // Extract the reserved variables named in $paramList, and remove them
         // from the parameters array. Variables remaining in parameters will be passed
         // along to Request::url as extra parameters.
+        $params = $router = $page = $component = $anchor = $escape = $op = $path = null;
         $paramList = ['params', 'router', 'context', 'page', 'component', 'op', 'path', 'anchor', 'escape'];
         foreach ($paramList as $parameter) {
             if (isset($parameters[$parameter])) {

classes/xml/PKPXMLParser.php

@@ -44,7 +44,7 @@ function __construct() {
 
 	function parseText($text) {
 		$parser = $this->createParser();
-
+		$handler = null;
 		if (!isset($this->handler)) {
 			// Use default handler for parsing
 			$handler = new XMLParserDOMHandler();
@@ -75,7 +75,7 @@ function parseText($text) {
 	 */
 	function parse($file) {
 		$parser = $this->createParser();
-
+		$handler = null;
 		if (!isset($this->handler)) {
 			// Use default handler for parsing
 			$handler = new XMLParserDOMHandler();