-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Child templates extend language instead of override #46353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
Conversation
|
please simplify the if statements, the else is not needed and maybe you find out why we load the language files twice? |
db0f75d to
efbb92c
Compare
efbb92c to
bf77a48
Compare
Probably has to do with the other document types (the HtmlDocument class is loading the language files I have to check the other ones) |
|
@dgrammatiko could you please add some test instructions? |
|
Hi @dgrammatiko, I have tried following the Testing Instructions to the letter so either it's not working, or I misunderstood something or there's a step missing? Image shows the folder/file structure with Child Template for PR46353, index.php copied and Language Folders en-GB and fr-FR emptied Image shows Child Template for PR46353 selected (wasn't mentioned in Testing Instructions but assumed that was needed) PR NOT Applied, yet Back to Top showing and not TPL_CASSIOPEIA_BACKTOTOP HELP? ;) |
|
You shouldn’t empty the folders but the files (.ini). Ie files should exist but with no content |
Ah, ok. Let me try that - thanks. That's a lot of files to empty lol, on it. Thankfully, a bit of command line magic will do that trick:
|
|
Unfortunately, @dgrammatiko, even after emptying the .ini files (while keeping them there), and NOT applying the PR, I still get Back to Top vs TPL_CASSIOPEIA_BACKTOTOP Image showing .ini files present but 0 bytes... |
|
@dgrammatiko could you please update your instructions to make the steps clearer? That should help with tests. |
|
Will try to do it after work |




Pull Request for Issue # .
Summary of Changes
Testing Instructions
<?= Text::_('TPL_CASSIOPEIA_BACKTOTOP'); ?>Without the PR will get
TPL_CASSIOPEIA_BACKTOTOPwith the PR will getBack to TopActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed