Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript linting not working anymore #28

Open
mxstbr opened this issue Oct 25, 2016 · 4 comments
Open

JavaScript linting not working anymore #28

mxstbr opened this issue Oct 25, 2016 · 4 comments

Comments

@mxstbr
Copy link

mxstbr commented Oct 25, 2016

I'm using eslint, and I'm used to seeing my linting errors inline. It says in the README this functionality should be there, but I'm not seeing any errors or warnings in VimBox 😢 any ideas how we could fix this?

@ericf89
Copy link

ericf89 commented Oct 25, 2016

I changed this line locally to ['eslint', 'flow'] and it started working for me. (Assuming eslint's already on your path and what not. @jordwalke I can submit a pr for this if you think it'd be useful.

I also added let g:jsx_ext_required = 0 to my .vimrc to get jsx highlighting in my .js files. Not sure if that's something everyone likes though...

@jordwalke
Copy link
Owner

Both of those sound great. Sorry about the stale JS setup, I haven't done a bunch of JS editing lately. I'll gladly accept pull requests for both of your improvements, @ericf89 .

@farazcsk-zz
Copy link

farazcsk-zz commented Dec 11, 2016

I am also having issues with linting, I attempted to edit the line stated above and it had no effect. I am not really sure what files I should be editing to customise vimbox (forgive me I am new to vim).

@broerjuang
Copy link

I try to follow your way to add eslint, but still not working @ericf89 . Is there any way I can make flow and eslint working. Or @farazcsk is it working now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants