From dbe35561980d77e93af8f1336bf5d030b9767e45 Mon Sep 17 00:00:00 2001 From: omkar-20 Date: Thu, 19 Dec 2024 15:24:25 +0530 Subject: [PATCH 1/4] Added 150 character minimum length in description box --- .../screens/GiveAppreciationScreen/index.tsx | 28 ++++++++++++++----- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx index cb3e257..182a69f 100644 --- a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx +++ b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx @@ -39,7 +39,8 @@ const paginationData = { const schema = yup.object().shape({ receiver: yup.string().required(messages.SELECT_COWORKER_NAME), core_value_id: yup.string().required(messages.SELECT_CORE_VALUE), - description: yup.string().required(messages.ENTER_DESCIPTION), + description: yup.string().required(messages.ENTER_DESCIPTION) + .min(150, 'Description must be at least 150 characters long.'), }); const AppreciationScreen = () => { @@ -159,12 +160,17 @@ const AppreciationScreen = () => { ( - + <> + + + Note: Description must be at least 150 characters. + + )} name="description" /> @@ -259,6 +265,14 @@ const styles = StyleSheet.create({ fontSize: 16, borderRadius: 12, }, + noteText: { + color: 'gray', + fontSize: 12, + marginTop: 4, + }, + noteBold: { + fontWeight: 'bold', + }, }); export default AppreciationScreen; From 8fee0d5b2c8c4994f2f531c8f94fee2144cb910a Mon Sep 17 00:00:00 2001 From: omkar-20 Date: Fri, 20 Dec 2024 12:04:19 +0530 Subject: [PATCH 2/4] Added error message in constant file --- src/app/Peerly/constants/message.ts | 1 + src/app/Peerly/screens/GiveAppreciationScreen/index.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/app/Peerly/constants/message.ts b/src/app/Peerly/constants/message.ts index 9d245fb..e45c8ab 100644 --- a/src/app/Peerly/constants/message.ts +++ b/src/app/Peerly/constants/message.ts @@ -19,4 +19,5 @@ export default { 'Your objection reason has been submitted successfully. We appreciate your feedback.', REWARD_SUCCESS: 'Your rewards has been submitted successfully. We appreciate your feedback.', + MIN_DESCRIPTION_LENGTH: 'Description must be at least 150 characters long.', }; diff --git a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx index 182a69f..9a3bd67 100644 --- a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx +++ b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx @@ -40,7 +40,7 @@ const schema = yup.object().shape({ receiver: yup.string().required(messages.SELECT_COWORKER_NAME), core_value_id: yup.string().required(messages.SELECT_CORE_VALUE), description: yup.string().required(messages.ENTER_DESCIPTION) - .min(150, 'Description must be at least 150 characters long.'), + .min(150, messages.MIN_DESCRIPTION_LENGTH), }); const AppreciationScreen = () => { From 989ae41c58d30e6508f26d1aec12ba0404ddf329 Mon Sep 17 00:00:00 2001 From: omkar-20 Date: Fri, 20 Dec 2024 16:22:01 +0530 Subject: [PATCH 3/4] Added description text in constant file --- src/app/Peerly/constants/message.ts | 1 + src/app/Peerly/screens/GiveAppreciationScreen/index.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/app/Peerly/constants/message.ts b/src/app/Peerly/constants/message.ts index e45c8ab..8885625 100644 --- a/src/app/Peerly/constants/message.ts +++ b/src/app/Peerly/constants/message.ts @@ -20,4 +20,5 @@ export default { REWARD_SUCCESS: 'Your rewards has been submitted successfully. We appreciate your feedback.', MIN_DESCRIPTION_LENGTH: 'Description must be at least 150 characters long.', + NOTE: 'Note:' }; diff --git a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx index 9a3bd67..fd27c7f 100644 --- a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx +++ b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx @@ -168,7 +168,7 @@ const AppreciationScreen = () => { multiline /> - Note: Description must be at least 150 characters. + {messages.NOTE} {messages.MIN_DESCRIPTION_LENGTH} )} From eb73335ad4b37735870096c4a5f3d4c45f738ceb Mon Sep 17 00:00:00 2001 From: omkar-20 Date: Fri, 20 Dec 2024 17:43:52 +0530 Subject: [PATCH 4/4] reduced description font size --- src/app/Peerly/screens/GiveAppreciationScreen/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx index fd27c7f..1c4f73c 100644 --- a/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx +++ b/src/app/Peerly/screens/GiveAppreciationScreen/index.tsx @@ -267,7 +267,7 @@ const styles = StyleSheet.create({ }, noteText: { color: 'gray', - fontSize: 12, + fontSize: 10, marginTop: 4, }, noteBold: {