Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make github import-app management command atomic #16

Closed
joshuadavidthomas opened this issue Nov 18, 2024 · 0 comments · Fixed by #18
Closed

Make github import-app management command atomic #16

joshuadavidthomas opened this issue Nov 18, 2024 · 0 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@joshuadavidthomas
Copy link
Owner

If the management command fails at any point, there are leftover model instances in the database. Should wrap the whole thing in transaction.atomic so it can roll back if anything fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make github import-app mgmt command an atomic transaction joshuadavidthomas/django-github-app
1 participant
@joshuadavidthomas