Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why seal PathComponentKind ? #80

Closed
Wicpar opened this issue Dec 4, 2023 · 2 comments
Closed

Why seal PathComponentKind ? #80

Wicpar opened this issue Dec 4, 2023 · 2 comments

Comments

@Wicpar
Copy link
Contributor

Wicpar commented Dec 4, 2023

The latest version breaks my usecase where i use parsed iso lang keys:

#[derive(Clone, Debug, Serialize, Deserialize, JsonSchema, Validate)]
#[serde(rename_all = "snake_case")]
pub struct I18nStruct {
    #[garde(dive)]
    pub i18n: HashMap<Lang, I18nName>,
}

why seal it ? people may need to have custom string-representable keys.

@jprochazk
Copy link
Owner

Can't remember why I did it. Maybe I was being overly defensive or something. Seems fine to unseal it

@jprochazk
Copy link
Owner

Fixed in #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants