fixing bullshit python packaging issues

Author: noahgift

Makefile

@@ -3,7 +3,7 @@ install:
 		pip install -r requirements.txt
 
 test:
-	python -m pytest -vv --cov=cli --cov=mlib --cov=utilscli test_mlib.py
+	python -m pytest -vv --cov=cli --cov=mlib --cov=utilscli --cov=app test_mlib.py
 
 format:
 	black *.py

app.py

@@ -12,19 +12,22 @@
 LOG = create_logger(app)
 LOG.setLevel(logging.INFO)
 
+
 @app.route("/")
 def home():
     html = f"<h3>Predict the Height From Weight of MLB Players</h3>"
     return html.format(format)
 
-@app.route("/predict", methods=['POST'])
+
+@app.route("/predict", methods=["POST"])
 def predict():
     """Predicts the Height of MLB Players"""
-    
+
     json_payload = request.json
     LOG.info(f"JSON payload: {json_payload}")
-    prediction = mlib.predict(json_payload['Weight'])
-    return jsonify({'prediction': prediction})
+    prediction = mlib.predict(json_payload["Weight"])
+    return jsonify({"prediction": prediction})
+
 
 if __name__ == "__main__":
-    app.run(host='0.0.0.0', port=8080, debug=True)
+    app.run(host="0.0.0.0", port=8080, debug=True)

cli.py

@@ -2,7 +2,8 @@
 import click
 from mlib import predict
 
-#var=
+# var=
+
 
 @click.command()
 @click.option(

requirements.txt

@@ -4,7 +4,8 @@ pylint==2.7.2
 pytest==6.2.2
 black==20.8b1
 click==7.1.2
-Flask==1.1.2
+Flask==1.1.4
+markupsafe==2.0.1
 joblib==1.0.1
 pytest-cov==2.11.1
 requests==2.25.1

test_mlib.py

@@ -4,6 +4,7 @@
 from click.testing import CliRunner
 from cli import predictcli
 import utilscli
+from app import app as flask_app
 
 
 @pytest.fixture
@@ -12,6 +13,15 @@ def test_array():
     feature = val.reshape(-1, 1)
     return feature
 
+@pytest.fixture
+def app():
+    yield flask_app
+
+
+@pytest.fixture
+def client(app):
+    return app.test_client()
+
 
 def test_format_input(test_array):
     assert test_array.shape == format_input(2).shape
@@ -37,3 +47,11 @@ def test_retrain():
     runner = CliRunner()
     result = runner.invoke(utilscli.cli, ["--version"])
     assert result.exit_code == 0
+
+
+# Smoke test Flask
+def test_index(app, client):
+    res = client.get('/')
+    assert res.status_code == 200
+    expected = "Predict the Height From Weight of MLB Players"
+    assert expected in res.get_data(as_text=True)

utilscli.py

@@ -3,6 +3,7 @@
 import mlib
 import requests
 
+
 @click.group()
 @click.version_option("1.0")
 def cli():
@@ -30,10 +31,13 @@ def retrain(tsize):
 @click.option("--host", default="http://localhost:8080/predict", help="Host to query")
 def mkrequest(weight, host):
     """Sends prediction to ML Endpoint"""
-    
-    click.echo(click.style(f"Querying host {host} with weight: {weight}",
-        bg="green", fg="white"))
-    payload = {"Weight":weight}
+
+    click.echo(
+        click.style(
+            f"Querying host {host} with weight: {weight}", bg="green", fg="white"
+        )
+    )
+    payload = {"Weight": weight}
     result = requests.post(url=host, json=payload)
     click.echo(click.style(f"result: {result.text}", bg="red", fg="white"))