Fixes navbar wrapping and gap issues #4514
Conversation
…ht border on last button when not in toolbar.
|
@toddparker - Can you ask Zach to test this on some devices? Thanks! |
|
Viewed test page using Android 2.3.4 in landscape and portrait and does fix the sub pixel issues I was encountering. Thanks @uGoMobi, I have been struggling with this one for a while. |
|
Has been tested on BB 9000 - 5.0.0.628 device by @jasondscott and the BB5 navbar wrapping issue didn't occur anymore. |
|
There's still some weird stuff happening on some BB5 devices. Galaxy Nexus - Android 4.0.X: No Problems Black Berry Bold - 7 Touch: No Problems Black Berry Curve - 5 Cursor:
Black Berry Storm II - 5.0 Touch:
Droid - Android 2.2 Touch: No Problems Palm Pre II - WebOS 2.0.1: No Problems Nokia N9 - MeeGo 1.2: No Problems Nokia Lumia 800 - WP7.5: No Problems HTC Trophy - WP 7.5: No Problems |
|
The BB5 Storm II Touch and BB5 Curve Cursor are also 9550 and 9330 respectively. |
|
@Aetherpoint - Great Job at testing all of these. Thanks! |
|
Wooowheeee! Thanks for the extra effort guy. |
|
@Aetherpoint - Thanks a lot for all the testing you did!! While you were posting this comment I received test results from RIM for the Curve which confirms what you already noticed... there is still an issue there because of the different screen width. The fix is not a generic one but custom, based on what has been reported. So I am going to make adjustments for the BB Curve and Storm which hopefully don't have a downside for other platforms/devices. Thanks again! Jasper |
…to percentages for older browsers (wrapping still occured on IE7 on certain screen widths).
|
I modified the fix. Test page has been updated. Results: IE7 (tested with IETester) - no wrapping, small gap 1 or 2px depending on screen width No wrapping and no gap: There is an issue with Opera desktop with 33.333% width - there is a big gap. That is already there with current code and I don't think we can fix that. We might have to test again on WP7 & WP7.5 @jasondscott will have it tested on BB Curve @agcolom - Anne, could you please look at the test page on some iOS devices? Thanks! |
|
Looks good on Bold 9000 (5.0) and Curve (5.0). Also tested on 9930 (7.1), which is still looking good. |
|
Issue on Opera desktop with 33.333% width blocks has been fixed in Opera version 12 |
…adding or border is set (note: not supported by IE7)
|
Just tested on the following: Kindle Fire 6.2.1 Everything works correctly and looks good |
|
Sorry, the testing was done by me, I didn't realize that username was logged in. |
|
I now finally get it... you are Zach! :-) Thanks for the test results! I am going to merge :-) |
|
That is me! No problem, hope it helped Zach McCarthy From: Jasper de Groot [[email protected]] I now finally get it... you are Zach! :-) Thanks for the test results! I am going to merge :-) Reply to this email directly or view it on GitHub: |
|
@uGoMobi Yeah, sorry for the confusion! I'm Andrew, also working under Todd at the Filament Group. Glad to see this working. |
Adjusted grid blocks percentage width to prevent wrapping because of subpixel problem on older browsers. Set them back for modern browsers.
Fixes #2270
Adjusted width of 50/50 grid blocks with -.5px negative margin to prevent wrapping on BB5.
Fixes #2159
Filled the gap caused by the subpixel problem with negative margin on the last button.
Fixes #3341
Set right border for last button and all right buttons in case of more than 5 buttons. Only when not in header/footer (i.e. when not full width).
Made sure that the navbar button styling as we intended always gets applied.
Test page and full changelog at http://ugomobi.github.com/navbar/