Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream results instead of accumulating them in memory #1

Open
arturom opened this issue May 2, 2016 · 0 comments
Open

Stream results instead of accumulating them in memory #1

arturom opened this issue May 2, 2016 · 0 comments

Comments

@arturom
Copy link

arturom commented May 2, 2016

Your implementation of the mysql2json protocol saves all the results to memory, so the number of results it can handle depends on the amount of free memory. The original implementation prints every line as it's own JSON object. In other words, it creates new-line-delimited JSON.

instead of doing this:

[
   {"row":  1},
   {"row":  2},
   {"row":  3}
]

it simply does this

{"row":  1}
{"row":  2}
{"row":  3}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant